locale_block: incorrect path for frontpage

Language Icons only add icons to the links, it doesn't generate the links themselves.

Right, of course. Anyway, if you want to have it fixed, it should go to 7.x (and then backported to 6.x) - of course, only if the bug still exists in the 7.x code base.

First off: A quick work around for your sites could be to use the Global Redirect module until the issue is fixed.

Second: Perhaps something smarter than $_GET['q'] == variable_get('site_frontpage', 'node') ? '' : $_GET['q'] could be used to determine if we're already in the frontpage? Obviously, when you're on "site/" or "site/en", $_GET['q'] will be '' - that is, not 'node' or any other string set as the site_frontpage variable. Or perhaps we could just remove the logic all together, as is done in the patch? This is what is done anyway, if not on the front page, so...

how about drupal_is_front_page() instead? Btw, it looks like this has already been changed in HEAD, so there must be another issue dealing with this, but I couldn't locate one.

Currently the code reads

    foreach ($languages[1] as $language) {
      $links[$language->language] = array(
        'href'       => $_GET['q'],
        ...

The code seems to be from #141996: Language switcher block, which used 'href' => $_GET['q']... and it doesn't seem to have changed in neither 6.x or 7.x.

(And now in the proper issue to boot.)

have the same problem, thank you I'll try it first ...

The proper way is indeed to call drupal_is_front_page(), and to use '' when it is. url() will take care of the rest.

subscribe. i didn't test this yet, but upon looking into code, i don't like that we are adding yet another SQL query for determining the path. Is there another solution?

please try this patch out.

@drewish:

+    $path  = drupal_is_front_page() ? '<front>' : $_GET['q'];

Please remove the spaces after the $path.

@meba:

We are not adding an SQL query. drupal_is_front_page() is cached, and it is called anyway (for example in menu_get_active_breadcrumb().

Damien Tournoud, at this point for a one character change you could re-roll the patch as easily as i could... or heck you could just edit the patch.

@drewish: why are you not allowing me to be lazy?

Here is a proper patch, I confirmed again it works as intended. Because the patch is trivial and several people already looked at it, I'm marking this as ready to go in.

Thanks guys, comitted. Marking down to 6.x for consideration.

Thanks, committed to Drupal 6.x.