Feed: LiveJournal

Issue: I'm seeing duplicates on EVERY refresh of the feed. Investigation into the database shows that the iid field is not being filled in (so the duplicate checking will not work).

Steps to reproduce: Create a feed, refresh it more than once. All feed items are added again on every refresh.

Solution: I was able to fix the problem by making the following changes:
simplefeed_item.module(181): In simplefeed_item_insert(), replace $node->iid with md5($node->url)
simplefeed_item.module(396): In simplefeed_item_feed_parse(), modify "$iid = md5($title . $link);" to be just "$iid = md5($link);"

Possible Cause: It looks like the $iid field is not being filled in when writing the database or node object.

CommentFileSizeAuthor
#2 t.patch1.53 KBm3avrck

Comments

alliax’s picture

alliax commented

The changes works on the most recent dev version. Thanks.

I don't understand HOW such a bug can exist for so long... Honestly, who can find an excuse? Come on.. :-)

m3avrck’s picture

m3avrck commented
Status: Active » Needs review
StatusFileSize
new t.patch1.53 KB

Indeed seems like Drupal 6 changed how the form execute work. Here is a proposed patch that doesn't change the actual value of $iid (since that will cause other issues).

Please try the attached patch for Drupal 6.

plinan’s picture

plinan commented

Thanks for the patch. I had the same problem but after the patch it seems to work fine now. Thanks!

miahawk’s picture

miahawk commented

I'm on drupal 6.4 and the patch didn't seem to clear up the issues with dups :(

miahawk’s picture

miahawk commented

update: I deleted the nodes that were created before I applied the patch, and the new nodes aren't being duplicated... so it appears to be working correctly now.

alliax’s picture

alliax commented

We cannot say we have an active module maintainer here, it means every single person who have downloaded simplefeed 6 will have basically a non working module, and the solution exists and is simple to apply, so why the release is not updated yet? incredible.

Maybe I'm wrong and the release IS updated, but I see the date still on 14th august.

m3avrck’s picture

m3avrck commented

@alliax there is no release for Drupal 6 yet.. views & cck are still in beta and affect SimpleFeed. Once those are released, 6.x will be released. Till then there is a DEVELOPMENT version, not an actual release like 5.x.

Maybe instead of complaining you should help test patches and write patches to get out an official release. Carry on mate.

m3avrck’s picture

m3avrck commented
Status: Needs review » Fixed

Now fixed: http://drupal.org/cvs?commit=142406

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.