Checked phplist block for anonymous subscription:

1. Email size from the block is too long. The size is 60. The inpot will overlapp other block in placed in the left or right.
I saw the size code commented in source code.
Is there a special reason for this?

2. Escape character(slash) should be removed.
The string "Paul" will shown as \"Paul\".

The fixes are attached in the module file of this bug.

Comments

paulbeaney’s picture

Hi,

Thanks for your comments and proposed patches.

I uncommented the size of the email field as I wanted it to grow/shrink according to whether it was used in a side panel or in the main content area. I guess I thought it would automatically change size to use the available width. I take it this in not the case in at least certain browsers?

I'm going to be spending a bit of time on this module again at the beginning of september, so I will roll your escape string code into the next update.

Regards,

- Paul

jbc’s picture

I have installed a (July dated) version of 5.x.1 dev (the latest one had critical errors), which produces this same fault.

From the discussion above, it sounds quite easy to fix, but I can't really understand what it being talked about re. the /"Paul"/ string.

If anyone can clarify, in order to allow me to debug this would be much appreciated.

jbc’s picture

I realise now, the string I referred to is nothing to do with the extended email field, which is the problem I am confirming.

I have checked this in Firefox 3.0, IE 8beta and Chrome. All repeat the error.

I really appreciate this module. PHPlist is a robust mailing list application (and open source) which is great to be able to combine with Drupal. I am planning on allowing subscriptions from two or three sites to ONE single list using this module. Thanks for development.

jbc’s picture

Title: html email size is too long in the block, newsletter name is not striped for slashes » html email size is too long in the block
Version: 5.x-1.0 » 5.x-1.x-dev

For the record, I fixed this issue with the addition of the following CSS:

.block-phplist .form-text {width:100%}

This works whether the form is in the sidebar or footer or content block regions.

Cool!

paulbeaney’s picture

Status: Active » Fixed

Hi,

I have added a setting on the phpList module admin page to allow the width of the email box to be set this way if preferred.

- Paul

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.