Thanks so much for adding support for photos to the private message module. It makes the "communicating with community members" much more personal.

It would be nice if (as a next step) the module supported ImageCache. This would allow us to specify a single consistent size for photos used in private messages. IMO it really helps line things up.

The Avatar Blocks module module leverages ImageCache. Maybe someone can look under the hood of that module to get some ideas.

I've attached an example from my site that shows what different sized avatars can do to your message display.

Thanks again!
Kevin

CommentFileSizeAuthor
#15 privatemsg_avatar_2.patch4.71 KBlitwol
#13 privatemsg_avatar_1.patch3.48 KBlitwol
#12 patch2.diff3.32 KBGeorge2
#4 patch.diff3.32 KBGeorge2
#1 pmsg.jpg38.28 KBwdfy
imagecache.jpg56.81 KBkmillecam

Comments

wdfy’s picture

wdfy commented
StatusFileSize
new pmsg.jpg38.28 KB

I'm facing same problems as you raised.

First, the avatar size is not constant in the private messages list, and i can't find the way to set it up.
Second, if a user is using the site default avatar, then the avatar will not be displayed on the private msg page.

I also attached a picture of my site here.
Thank you.

Fei Zhao

George2’s picture

George2 commented
Assigned: Unassigned » George2

this has annoyed the heck out of me too, and renders it useless for me (users can upload large images as an original profile image) so i'm working on a patch to allow you to choose an imagecache preset from the options, and then privatemsg will use it.

should be ready for testing later today

George2’s picture

George2 commented

in need of testing, and probably could be improved by someone with more knowledge :)

[edit] patch removed for one below

George2’s picture

George2 commented
Status: Active » Needs review
StatusFileSize
new patch.diff3.32 KB

ok, i later found out that you're using avatar_select then this module returns the full http://.... path to the avatar, which imagecache can't deal with, so i've had to reset the http:// path to the original account->path

B.P.B’s picture

B.P.B commented

What should be done after patching the module in order to see user images within private messages?

Is this patch suppose to integrate privatemsg+imagecache with Avatar Blocks?

Please help.

George2’s picture

George2 commented

as the patch is for privatemsg, i'd guess that it's has nothing to do with avatar blocks.

i'd also guess that as this topic is about integrating imagecache with privatemsg, that the patch integrates imagecache with privatemsg

once patched, go to the privatemsg settings, and you will see an imagecache selection box for you to choose the preset to use for the privatemsg's

as you're asking such basic questions, you need imagecache installed, and you need some presets set up, and then away you go. without the patch, images should show in the private message list. if they don't, then you have a problem.

B.P.B’s picture

B.P.B commented

I am running imagecache + imagefield + CCK + views. My preset "thumb" is used to display a thumbnail gallery using views.

Before and after the patch I did not see photos in my message list. After the patch there is an option in privatemsg to select "thumb", but it does not display the user's uploaded picture.

It seems I do have a problem.

George2’s picture

George2 commented

as this is a thread about the imagecache patch, and you have a completely different problem, nothing to do with the patch, please start a support request thread

George2’s picture

George2 commented

as a post thought, it may just be more efficient to, instead of checking for the strpos of 'http://', just to use the account->path regardless.

any thoughts?

kmillecam’s picture

kmillecam commented

Hey George2,

Thanks for taking the time to create this patch.

I've applied it to my production site and it sure makes the images look better.

Thanks again,
Kevin

litwol’s picture

litwol commented
Status: Needs review » Needs work
George2’s picture

George2 commented
Status: Needs work » Needs review
StatusFileSize
new patch2.diff3.32 KB

updated

litwol’s picture

litwol commented
Assigned: George2 » Unassigned
StatusFileSize
new privatemsg_avatar_1.patch3.48 KB

Reviewed, fixed, and attached the new patch.

Please review.

George2’s picture

George2 commented
Status: Needs review » Reviewed & tested by the community
litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new privatemsg_avatar_2.patch4.71 KB

#13 has wrong patch. here's the right one.

George2’s picture

George2 commented
Status: Needs review » Reviewed & tested by the community
litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed

Thanks George2!
http://drupal.org/cvs?commit=137780

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.