Batch subqueue creation should use form_submit_finish

ezra-g - August 15, 2008 - 19:29
Project:Smartqueue Per User
Version:5.x-0.4
Component:Code
Category:bug report
Priority:normal
Assigned:ezra-g
Status:closed
Description

Because the qid has not been set when the queue edit form is submitted, user subqueues created with batch creation have their qids set to 0. This patch disables batch creation in the queue edit form until the queue has been created.

#1

ezra-g - August 15, 2008 - 19:30
Assigned to:Anonymous» ezra-g
AttachmentSize
sq_u_disable.patch 1.67 KB

#2

ezra-g - August 15, 2008 - 19:30
Version:5.x-0.4» 6.x-6.x-dev

#3

ezra-g - August 16, 2008 - 15:39
Title:Batch subqueue creations sets qid = 0» Batch subqueue creation should use form_submit_finish
Version:6.x-6.x-dev» 5.x-0.4
Priority:critical» normal
Status:patch (to be ported)» active

Actually, this isn't the best solution. Merlinofchaos thought ahead, and provided a nodequeue_api_queue_form_submit_finish, that runs after the queue is created. Nice API!

Setting this back to active/normal since the problem is solved currently, but could be solved *better*.

#4

ezra-g - August 17, 2008 - 03:56
Status:active» fixed

Committed to 5 and 6.

#5

Anonymous (not verified) - August 31, 2008 - 04:02
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.