TestingParty08: Main help page

changing status

Hmm, weird. I applied this again and it didn't fail for me.

OK, let me dig into it more tonight.

good mystery! This patch worked great on my test server, and failed with the same errors webchick saw on my neighbor's server. Good thing we were at the BADCamp testing party and able to check things out pretty quick.

this patch is testing for <a href="/admin/help/$module"> links, but depending on your server settings, the links might not come out like this.
checking against something like <a href="'.url('admin/help/' . $module) . '"> allows the tests to pass on our setups.

flobruit and chx also mentioned that having a help_test module that just enables hook_help might be more appropriate to test that help links appear, and actually clicking the link and getting a positive response would be more specific.

I will try to post a new patch soon, unless someone beats me to it :)

This patch applies, the tests look good, and they all pass.

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

Re-rolled to remove the extra line mentioned in #17.

Mmm, the text in the asserts can be made shorter. We don't need to assert on the entire 3 line paragraph.

I'm not sure we need the test module. We can use any of the core modules do perform the same test.

There is some code commented out in an odd way.

I think we do need the test module. We are testing the functionality of hook_help(), we aren't testing whether poll or some other core module implements it correctly. The assert could check against shorter text though.

Shortened the long text assert to 1 line, and rerolled against HEAD to remove fuzz

I caught a typo in the test's description, and also tried to change the help.css test to xpath for actual verification that the HTML was, in, fact, there. That didn't work so good, so I left it alone. All looks good.

The last submitted patch failed testing.

The last submitted patch failed testing.

Test slave glitch.

rerolled against HEAD

I think my comments from #22 still apply - we want to test the functionality of hook_help(), not whether a particular module like poll or blog implements it. But if the consensus is that we don't need it, I'm fine with removing it.

Actually #472642: Remove "implementation of" nominalizations from Docblocks just got committed, so instead of Implementation of hook_help(). you need Implement hook_help().

Looks good.

Patch re-roll because #475596: [meta-issue] Fix the unholy abomination that is the welcome screen was committed.

rerolled against HEAD and incorporated the change stella noted from #475596: [meta-issue] Fix the unholy abomination that is the welcome screen

The last submitted patch failed testing.

The last submitted patch failed testing.

The last submitted patch failed testing.

Is this a stray comment?

// Loading these (and other?) modules will result in failures?

Still looks good! Somebody commit this puppy, quick

bad trial run of new testing bot

Try this AutoBot one more time...

Rerolled against HEAD with a few changes.

I got rid of the help_test.module, since no one seems to like it. I still think it's a little silly to require poll and blog module's help, but it works. No other barriers to getting committed have been posted to this issue.

D7 now uses the seven theme so:

• updated the page title html we're looking for
• stop checking for breadcrumbs, since seven doesn't use them

The last submitted patch failed testing.

This is nice cleanup, lots of commented out lines removed, saner test.

Automatically closed -- issue fixed for 2 weeks with no activity.