Download & Extend
Issues

TestingParty08: Filter tips - short tips

Posted by cwgordon7 on August 16, 2008 at 2:18am
Project:Drupal core
Version:8.x-dev
Component:filter.module
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

We need to test the functionality of Drupal's filter tips. This issue focuses on the "short" filter tips - the ones that appear in an unordered list on the node/add page.

Suggested assertions:
- Create a filter with all of the core filters enabled, make sure the proper tips show up on the node/add page.
- Create several filters, and make sure each has its proper tips show up on the node/add page.
- Make sure the link to the longer tips shows up on the node/add page.

Login or register to post comments

Comments

#1

Posted by neurovation.kiwi on August 28, 2008 at 8:51am

hi folks,

we just are onto it - expect a patch in the next days ;)

#2

Posted by neurovation.kiwi on August 31, 2008 at 9:29am
Status:active» needs review

hi folks,

so here i got some test that does what is described above.

and i found a bug as well - "Correct broken HTML" does not have a help tip.

will file a bug report as well.

AttachmentSizeStatusTest resultOperations
filterTips.patch3.8 KBIdleFailed: Failed to apply patch.View details | Re-test

#3

Posted by neurovation.kiwi on August 31, 2008 at 10:51am

well, ok - just found out i was a little bit too rigid.

so here is now a complete patch for the test class, which ignores missing help texts.

cu

AttachmentSizeStatusTest resultOperations
filterTips.patch3.54 KBIdleFailed: Failed to apply patch.View details | Re-test

#4

Posted by catch on September 20, 2008 at 11:54pm
Status:needs review» needs work

Test runs fine and passes but there's a few code style issues - tabs instead of spaces, munging together of variable names (should be $foo_bar), and code comments should read as full sentences.

#5

Posted by lilou on June 14, 2009 at 7:24pm
Component:tests» filter.module
Status:needs work» needs review

Few code style corrections.

AttachmentSizeStatusTest resultOperations
issue-295985.patch3.57 KBIgnored: Check issue status.NoneNone

#6

Posted by lilou on June 14, 2009 at 7:25pm
AttachmentSizeStatusTest resultOperations
issue-295985.patch3.57 KBIdleFailed: 11132 passes, 27 fails, 20 exceptionsView details | Re-test

#7

Posted by System Message on June 14, 2009 at 7:40pm
Status:needs review» needs work

The last submitted patch failed testing.

#8

Posted by lilou on June 17, 2009 at 11:51am

Re-roll.

Fail :

        $this->assertEqual(htmlentities((string)$fields[0]->ul->li[$filter->delta - $missingHelpCount]), $tips[$filter->delta], t('Filter help text match !filter', array('!filter' => $filter->name)));
AttachmentSizeStatusTest resultOperations
issue-295985.patch3.72 KBIdleFailed: 11139 passes, 4 fails, 12 exceptionsView details | Re-test

#9

Posted by lilou on June 17, 2009 at 11:51am
Status:needs work» needs review

#10

Posted by lilou on June 17, 2009 at 12:05pm

AttachmentSizeStatusTest resultOperations
filter-failed.png125.88 KBIgnored: Check issue status.NoneNone

#11

Posted by System Message on June 17, 2009 at 12:10pm
Status:needs review» needs work

The last submitted patch failed testing.

#12

Posted by lilou on June 17, 2009 at 12:24pm
Status:needs work» needs review

HEAD is broken : http://testing.drupal.org/node/35

#13

Posted by System Message on June 18, 2009 at 3:40pm
Status:needs review» needs work

The last submitted patch failed testing.

#14

Posted by catch on October 17, 2009 at 7:54am
Category:bug report» task
Priority:critical» normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

#15

Posted by sun on November 28, 2010 at 9:55pm
Version:7.x-dev» 8.x-dev