TestingParty08: Comment signatures
cwgordon7 - August 16, 2008 - 02:18
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
We need to test the ability for users to set default comment signatures.
Suggested assertions:
- Make sure user-set signature appears after comment is submitted.
- Make sure comments' signature changes after the user's signature is changed.
#1
This is pretty ugly, postComment probably needs to go into DrupalWebTestCase for a start, and it needs finishing up. But still, pancakes!
#2
Here goes. postComment is moved out of comment.test and becomes drupalPostComment in drupalWebTestCase() - otherwise unchanged.
Finished off the test, which passes. Kyle Matthews was my partner for the testing party, so should get credit on commit.
#3
slight tidy up.
#4
#5
Patch looks good, just some formatting fixes.
I understand that unlike other drupalCreate*() methods, drupalPostComment() actually posts the information rather than creating an item programmatically. However, for consistency, shouldn't the method be named drupalCreateComment()?
Otherwise RTBC.
#6
forgot patch
#7
Patch had 4 failures and several successes. Looks like it needs to be updated.
#8
Fixing the critical / pending bugs queues to reflect things which are really bugs or release critical.