We need to test the ability for users to set default comment signatures.

Suggested assertions:
- Make sure user-set signature appears after comment is submitted.
- Make sure comments' signature changes after the user's signature is changed.

CommentFileSizeAuthor
#6 signature_test-296009-5.patch11.71 KBfloretan
#4 signature.test12.45 KBcatch
#3 signature.test12.3 KBcatch
#2 signature.test12.73 KBcatch
#1 signaturetest.patch3.79 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work
StatusFileSize
new signaturetest.patch3.79 KB

This is pretty ugly, postComment probably needs to go into DrupalWebTestCase for a start, and it needs finishing up. But still, pancakes!

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new signature.test12.73 KB

Here goes. postComment is moved out of comment.test and becomes drupalPostComment in drupalWebTestCase() - otherwise unchanged.

Finished off the test, which passes. Kyle Matthews was my partner for the testing party, so should get credit on commit.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new signature.test12.3 KB

slight tidy up.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new signature.test12.45 KB
floretan’s picture

floretan commented

Patch looks good, just some formatting fixes.

I understand that unlike other drupalCreate*() methods, drupalPostComment() actually posts the information rather than creating an item programmatically. However, for consistency, shouldn't the method be named drupalCreateComment()?

Otherwise RTBC.

floretan’s picture

floretan commented
StatusFileSize
new signature_test-296009-5.patch11.71 KB

forgot patch

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Needs work

Patch had 4 failures and several successes. Looks like it needs to be updated.

catch’s picture

catch
he/him
Primary language English
commented
Component: tests » base system
Category: bug » task
Priority: Critical » Normal

Fixing the critical / pending bugs queues to reflect things which are really bugs or release critical.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.