Download & Extend

TestingParty08: Comment signatures

Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

We need to test the ability for users to set default comment signatures.

Suggested assertions:
- Make sure user-set signature appears after comment is submitted.
- Make sure comments' signature changes after the user's signature is changed.

Comments

#1

Status:active» needs work

This is pretty ugly, postComment probably needs to go into DrupalWebTestCase for a start, and it needs finishing up. But still, pancakes!

AttachmentSizeStatusTest resultOperations
signaturetest.patch3.79 KBIgnored: Check issue status.NoneNone

#2

Status:needs work» needs review

Here goes. postComment is moved out of comment.test and becomes drupalPostComment in drupalWebTestCase() - otherwise unchanged.

Finished off the test, which passes. Kyle Matthews was my partner for the testing party, so should get credit on commit.

AttachmentSizeStatusTest resultOperations
signature.test12.73 KBIgnored: Check issue status.NoneNone

#3

slight tidy up.

AttachmentSizeStatusTest resultOperations
signature.test12.3 KBIgnored: Check issue status.NoneNone

#4

AttachmentSizeStatusTest resultOperations
signature.test12.45 KBIgnored: Check issue status.NoneNone

#5

Patch looks good, just some formatting fixes.

I understand that unlike other drupalCreate*() methods, drupalPostComment() actually posts the information rather than creating an item programmatically. However, for consistency, shouldn't the method be named drupalCreateComment()?

Otherwise RTBC.

#6

forgot patch

AttachmentSizeStatusTest resultOperations
signature_test-296009-5.patch11.71 KBIgnored: Check issue status.NoneNone

#7

Status:needs review» needs work

Patch had 4 failures and several successes. Looks like it needs to be updated.

#8

Component:tests» base system
Category:bug report» task
Priority:critical» normal

Fixing the critical / pending bugs queues to reflect things which are really bugs or release critical.

nobody click here