Spin-off from #191509: If transliteration module is not installed, hide the transliteration checkbox. Remove the UI for setting the handling of punctuation, so it's only configurable via site variables. One of the things we need to figure out is the most sensible defaults.

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I think they should all be "remove" except for the setting for whatever character they use as the separator which should be set to "do nothing."

Freso’s picture

Freso commented

But we won't know, when deciding the standards, what they choose to use as separator. I use "_" as I prefer the human readability over the (alleged) SEO of "-" - and both are safe to use, so I'd vote for a "do nothing" for both of those anyway. I think we need to figure out which ones are "safe" and which ones aren't. This means URL entities (:/.#?&), XML/HTML entities ("><'), and... ? "\" should probably be removed as well, as Windows use that. So... anything left on the list, besides "-" and "_"?

Freso’s picture

Freso commented

Once #212208: allow other modules to affect strings (to help with custom accent/string replacement) goes in, other modules can plug into the process and customise the handling of "punctuation" characters. So I think we should just removed them from 6.x-2.x - site variables and all - and let people customise through modules if they really need to do things differently from our (sane'n'sensible ;)) defaults.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

This does get us into a tricky spot - what if they change the default separator. The default separator should always be set to do nothing, so we'll need to do that automatically for them if we remove this control.

Freso’s picture

Freso commented

Or... we could remove "punctuation" before replacing spaces with the replacement? (E.g. "awesome_function() is awe-some" would first become "awesomefunction is awesome" and then "awesomefunction-is-awesome".)

mably’s picture

mably commented
Issue summary: View changes
Status: Active » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.