Some includes are not anchored [#296194]

This is in db_set_active() (http://api.drupal.org/api/function/db_set_active/6) in database.inc in D7 and D6, and db_connect() in database.mysql.inc in D5.

This issue would be superceded in D7 by #259623: Broken autoloader: convert includes/requires to use absolute paths if that lands, but the bug remains in D6 and D5 (see e.g. http://drupal.org/node/259375).

Comment	File	Size	Author
#5	296194_pathauto_anchor_includes.patch	978 bytes	greggles

Comments

Comment #1

damien tournoud commented 16 August 2008 at 22:30

Title:

install.inc is included as 'includes/install.inc' instead of './includes/install.inc'

» Some includes are not anchored

Widening the issue:

# egrep -r "include_once '[^.]" *
5.x/includes/database.mysql.inc:      include_once 'includes/install.inc';
5.x/includes/database.mysql.inc:      include_once 'includes/install.inc';
6.x/install.php:    include_once 'includes/batch.inc';
6.x/install.php:      include_once 'includes/locale.inc';
6.x/install.php:    include_once 'includes/batch.inc';
6.x/install.php:    include_once 'includes/locale.inc';
6.x/install.php:      include_once 'includes/locale.inc';
6.x/install.php:    include_once 'includes/batch.inc';
6.x/install.php:    include_once 'includes/locale.inc';
6.x/includes/database.inc:    include_once 'includes/install.inc';
6.x/modules/locale/locale.module:  include_once 'includes/locale.inc';
7.x-dev/install.php:    include_once 'includes/batch.inc';
7.x-dev/install.php:      include_once 'includes/locale.inc';
7.x-dev/install.php:    include_once 'includes/batch.inc';
7.x-dev/install.php:    include_once 'includes/locale.inc';
7.x-dev/install.php:      include_once 'includes/locale.inc';
7.x-dev/install.php:    include_once 'includes/batch.inc';
7.x-dev/install.php:    include_once 'includes/locale.inc';
7.x-dev/includes/database.inc:    include_once 'includes/install.inc';
7.x-dev/modules/locale/locale.module:  include_once 'includes/locale.inc';

Comment #2

gpk commented 16 August 2008 at 22:47

Hmm I wonder, when an expression is used to determine the file to include_once or require_once ... whether it always properly anchored...

Comment #3

gpk commented 10 September 2008 at 10:21

Version:

7.x-dev

» 5.10

In 5.x, as well as the unanchored include_once 'includes/install.inc'; on lines 62 and 99 of database.mysql.inc, there also looks to be a problem on line 74 of color.module which has include $file; but $file will begin with "themes" or "sites" rather than "." or "/". Changing it to include "./$file"; should fix that. Should the "include" also be changed to "include_once"? (There's another straight "include" on phptemplate.engine line 412).

Also there are a couple of places that use include_once(<file>) syntax, but as that's not a bug it don't need fixing I guess.

A bit of grepping revealed a few further places where the filename referenced by include_once or require_once is a variable. However it looks as though the variable begins with './' in these cases. For reference they are:
install.php:416
module.inc:229
image.inc:36
database.inc:118
install.inc:271
install.inc:687
install.inc:699
install.inc:727