Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2008 at 08:10 UTC
Updated:
17 Oct 2009 at 07:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerhere is a patch | it tests some static and some random headers
Comment #2
cwgordon7 commentedThis has a few coding standards issues:
1.
+ * Test drupal_get_headers()should have a period at the end.2.
+class DrupalGETHeadersTestCaseshould be DrupalGetHeadersTestCase for consistency.3.
+ * Implementation of hook_getInfo()should be+ * Implementation of getInfo().4.
+ );should be less indented.5.
+ function testDrupalGETHeaders() {should be+ function testDrupalGetHeaders() {for consistency.6.
testDrupalGetHeadersshould have a comment block.7. All comments should begin with a capital letter and end with a period.
Also, a minor concern - won't this also *actually send out the header* during the batch request, making everything confused?
Comment #3
damien tournoud commentedObviously this cannot work. We need to create a special test module registering a menu path that returns special headers.
Comment #4
catchFixing the critical / pending bugs queues to reflect things which are really bugs or release critical.