TestingParty08: l and active class needs a test

Added 2 tests which are testing the active class being added, and the class specified in the $options array being added.
(tthbonnier, nagba)

rerole of the test, with the right root path, with a little more documentation

Few minor issues:

- we don't have phpdoc for getInfo()
- doesnt needs an apostrophe (or maybe use $this->randomName() instead)
- The references to l should probably be l() to make it easier to spot it's a function when scanning through.

thx for the review

i was not sure what you meant with "doesn't needs an apastrophe but i think you meant the link title

i also added a line wrap, because i think its much better to read

rerolled this patch, thx testbot

- The references to l should probably be l() to make it easier to spot it's a function when scanning through.

I'm still wondering what you mean with this

here is a rerole of this patch

is there a better way to check for an applied class? Using $this->assertEqual() seems to rely a little too heavily on the format of a link never changing. Maybe a check via regular expression instead?

ok, I guess since I complained I should find a better way. I used a preg_match() to check that the class is added to the link, so we're not checking against the specific structure of a link tag anymore. Also updated the patch against the latest HEAD.

resetting for testbot

rerolled against HEAD

rerolled against HEAD, there were changes introduced in #310139: drupal_query_string_encode() should not call drupal_urlencode(). Also fixed spacing issues with testDrupalQueryStringEncode().

rerolled against HEAD, also removed some extra spaces that were introduced in #296324: TestingParty08: url() for internal urls need a thorough test (sorry).

hmm, patch still applies without fuzz for me. resetting for testbot.

This patch was tested before detailed failure messages were added. Re-testing.

Rerolled the patch so it applies to HEAD again. Also, since #326539: Convert 'class' attribute to use an array, not a string landed, class attrributes are now arrays instead of strings.

Added an additional test (see OP) to verify that the active class is also added when a custom class is present.

Sorry, but tests don't qualify as critical anymore.

This test passed.

Committed to CVS HEAD. Thanks.