Update module to use Drupal 6 module_load_include functionality

Michael Curry - August 17, 2008 - 16:04
Project:Classified Ads
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:minor
Assigned:milesgillham
Status:closed
Description

This is a fairly big module, so we should investigate breaking up the module to work with the new mechanism.

http://drupal.org/node/114774#module_load_include

#1

milesgillham - June 27, 2009 - 13:26
Assigned to:Michael Curry» milesgillham

Aye.

#2

milesgillham - August 6, 2009 - 06:47
Priority:normal» minor
Status:active» postponed

This has been done in -dev branch for ed_classified.module I've marked it as fixed in the CVS but only because strictly I've converted require_once to module_include. Further thought would need to be given as to how and when the includes are pulled in and that's a major structural issue I think. Presently they're all pretty much needed all the time.

Will leave this on the back-burner for the moment and bring to the fore as the module grows further and performance becomes a bigger concern.

Cheers,

Miles

#3

milesgillham - August 6, 2009 - 10:50
Status:postponed» fixed

Silly me, I was bitten by drupal_get_path() not available at module load time which module_load_include() relies on. I've made some structural changes in -dev so ed_classified should be a little more efficient in terms of inclusion overheads.

Cheers,

Miles

#4

System Message - August 20, 2009 - 11:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.