Simpletest reports a fail for "Found the requested form at" yet it also passes for "Found the Submit button" on the same form. The first message should more accurately read something like "Found the requested fields." Thanks to dmitrig01 and catch for responding to this in #drupal.

CommentFileSizeAuthor
#3 simpletest_forms_message_d7.patch940 bytesezra-g
#2 simpletest_form_message.patch975 bytesezra-g

Comments

catch’s picture

catch
he/him
Primary language English
commented
Project: SimpleTest » Drupal core
Version: 6.x-2.2 » 7.x-dev
Component: Code » simpletest.module

Bumping this to core because I think boombatower is doing backports to 6.x too. This message is definitely confusing, and fields seems more accurate.

ezra-g’s picture

ezra-g commented
StatusFileSize
new simpletest_form_message.patch975 bytes

I already rolled the patch against simpletest 6.2, so here it is for purposes of the backport. It changes the text in question to 'Failed to find the requested form fields at @path'

ezra-g’s picture

ezra-g commented
Status: Active » Needs review
StatusFileSize
new simpletest_forms_message_d7.patch940 bytes

Here is the patch for Drupal 7.

boombatower’s picture

boombatower commented
Status: Needs review » Closed (duplicate)

This is related to [#http://drupal.org/node/293099] I think they should be merged.

Doesn't follow the convention:

Failed to find the requested form fields at @path

We state things in the positive and let the assertion result explain the state.

Changed to:

Found the requested form fields at @path

Since other thread already existed and these are similar (and minor) patches I've merged to other thread.

And yes SimpleTest 6.x-2.x is a backport of 7.x stuff.