taxonomy_select_nodes() uses 'feed_default_items' system variable when pager is FALSE

Steps to reproduce:

- call taxonomy_select_nodes() with pager = FALSE

Expected behaviour:

- receive a database result with all nodes matching tids.

Observed behaviour:

- only 10 results returned.

Upon checking the code for taxonomy_select_nodes I noticed that if you pass FALSE for the $pager argument, it uses the system variable 'feed_default_items' (or 10 if it isn't set). If you want to return more than 10 items using this function you need to set this variable in admin/content/rss-publishing. And if you want to return more than 30 you are out of luck, unless you go ahead and edit the variable by hand.

I don't think feed_default_items is the right variable to be using here. How many nodes you want returned from this function and how many items you want displayed in your RSS feed are two very different things.

While not technically a bug, I had to look at the source for the function (and then grep for feed_default_items to see where to set it) to get it to return more than 10 nodes. Perhaps the documentation needs to be changed.

Or, even better- something like this instead:

Have another argument, $items, which defaults to NULL. If $pager is FALSE, and $items != NULL, use $items as the number of nodes you want returned. If $pager is FALSE and $items is NULL, by all means use feed_default_items.

I realise this breaks the API, so won't be included in 5.x Perhaps something for HEAD.

I will write a patch for HEAD if people agree with my proposed change.