Hi,

I'm testing Ubercart 2 working on drupal 6. It begin to be really usable and pretty stable for a developpment snapshot (try the latest bazaar).

I updated your module to work with D6 and UC2, here is a the module in a zip file above.

Do you plan to create a 6.x branch for your module ? It would be cool !

thanks

zmove

CommentFileSizeAuthor
#2 uc_aac.zip9.37 KBzmove
uc_aac.zip17.31 KBzmove

Comments

cyu’s picture

cyu commented
Status: Needs review » Needs work

zmove, thanks for handling this upgrade. If Ubercart code looks solid I am glad to start the 6 branch of this module. A couple things...

1. There is a random alert in there.
2. Can you apply this code against HEAD or the latest d5 CVS code as opposed to 1.3? There are a couple needed updates missing from version 1.3 of this module.
3. jquery.form.js is in core in d6, so you can remove it from this module and do
drupal_add_js('misc/jquery.form.js');

zmove’s picture

zmove commented
StatusFileSize
new uc_aac.zip9.37 KB

Hi,

Here is the modified version is requested so :

1 - Removed the random alert
2 - Applied the code against the CVS version of the .module
3 - Removed the jquery.form.js file in the module and changed the link to get the core one.

cyu’s picture

cyu commented

Cool, that looks good. You were actually on the right track replacing drupal_to_js with drupal_json in your original upgrade. I was incorrectly setting the header to plain/text instead of text/javascript, which drupal_json will take care of. I'll add that in with your upgraded module and create a 6 branch.

zmove’s picture

zmove commented

Thank you very much. :). I think this will be the first official drupal 6 release of an Ubercart contrib ;)

cyu’s picture

cyu commented
Status: Needs work » Fixed

Ok, it is up there now. Thanks again for performing the upgrade.

http://drupal.org/node/296878

zmove’s picture

zmove commented

Thank you for creating the branch ! :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.