6.x port

meba - August 18, 2008 - 15:37
Project:Advanced Contact
Version:5.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi,
I am attaching a patch for 6.x port of this module.

AttachmentSize
advcontact-6.x.patch1.64 KB

#1

meba - August 18, 2008 - 19:25

Rerolling, fixed a typo in help and fixed a bug that this string wasn't exported into translation files.

AttachmentSize
advcontact-6.x.patch 2.61 KB

#2

neclimdul - August 20, 2008 - 21:55

Thanks! I'll take a look.

#3

neclimdul - August 20, 2008 - 22:18

Could you leave the help text the way it was? If there is a problem can we handle it separately so its easier to review?

#4

neclimdul - August 21, 2008 - 16:38
Status:needs review» needs work

per my comments

#5

mikey_p - September 5, 2008 - 21:36

Removing help text modifications.

Simplest. Update. Ever.

AttachmentSize
advcontact_296783_5.patch 1.33 KB

#6

meba - November 2, 2008 - 10:34
Status:needs work» needs review

#7

a_c_m - December 3, 2008 - 12:44
Status:needs review» reviewed & tested by the community

Works for me, really simple patch so i think RTBC.

#8

jweberg - March 9, 2009 - 17:22

Any idea when this will be rolled out as a stable 6.x version?

#9

sinuz - March 25, 2009 - 12:32

subscribing

#10

awry - March 27, 2009 - 00:08

The patch basically works for me. There's some weird grammar in one spot, though, which I changed like so:

--- advcontact.module   (revision 78)
+++ advcontact.module   (working copy)
@@ -38,7 +38,7 @@
           '#required' => TRUE,
         );
         $form['contact_information']['#value'] =
-          t('You can leave us a message about using the contact form below regarding: @category', array('@category' => $cat));
+          t('Use the form below to send a message to our @category team. Thanks for your interest.', array('@category' => $cat));
       }
     }

#11

neclimdul - March 27, 2009 - 04:19
Status:reviewed & tested by the community» fixed

Thanks guys, took a little of both patches(no message change). Forgot to credit but thanks a lot!

#12

System Message - April 10, 2009 - 04:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.