Posted by chayner on August 18, 2008 at 7:27pm
| Project: | Pathologic |
| Version: | 5.x-1.1-beta7 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I noticed that another issue ticket was entered for 6.x, and didn't know if my issue was the same in 5.x. I am using TinyMCE to allow people to enter in anchor tags, and then select the anchors with IMCE. Unfortunately, it's converting the urls to be:
http://www.website.com/%2523general_faq
Instead of:
http://www.website.com/faq#general_faq
Do you have any ideas? I have tried to rearrange the ordering in my input filter, but right now I have the order of Typogrify > URL filter > Pathologic (I have also tried to have Pathologic first in that string).
Comments
#1
What's probably happening is that something before Pathologic is converting #general_faq to %23general_faq (as %23 is a URL-escaped #) and Pathologic is in turn converting that to %2523general_faq (as %25 is a URL-escaped %). I highly doubt Pathologic is double-escaping things like this by itself. Are you sure everything is working fine even when you disable Pathologic?
#2
Yep, I have first rearranged my input filters, to be Pathologic > URL Filter > Typogrify and I get the following links still:
http://www.website.com/%2523general_faq
If I disable Pathologic (and keep the ordering the same), I get:
http://www.website.com/subdirectory/faq#general_faq
The one thing I did notice was that with Pathologic installed, the whole URL Alias gets wiped out -- might this be an indication of what is going wrong?
#3
Arg.
Okay. Soon, I'm going to create a new release of Pathologic for D6. I'm also going to backport it to D5 and release that as a dev release, while deleting the D5 Beta 7 release, so that way the only D5 version shows up nice and red on the project page. Then I'm going to forget the D5 version exists and tell people they're on their own when they submit issues about it.
Sound like a deal?
#4
WTF? So, everyone using D5 and your module are SOL once you upgrade it to D6? Will you get anyone else to maintain that branch, or should we just forget your module exists completely (from now on. how do I know you won't pull the same stunt in D6 or D7 or D8, etc...)
Sound like a deal?
#5
If someone else wants to officially maintain it, they can maintain it. Personally, I have no interest in maintaining and supporting it, and, may I remind you, am under no obligation to do so.
(The D6 version already exists, by the way… has for months.)
#6
The issue happened when the url was passed with ONLY a fragment. Attached is the patch to modifying the _pathologic_do_href function to check for only a fragment, and pass the current URL if that's the case.
#7
Okay, a new D5 dev release is on its way. The system only packages dev releases once every twelve hours, so it'll take a while before it appears. It should offer feature parity with the just-released Beta 13 release of the D6 branch. I didn't test it a whole lot, though.
#8
#9
Automatically closed -- issue fixed for 2 weeks with no activity.