I am attaching a version of listhandler.module that contains changes I made to integrate with the following modules: mailhandler, mailsave, comment_upload, comment_subscribe. With the changes I made to listhandler, I have a maillist attached to a forum w/bi-directional support for emails becoming forum topics, email replies becoming comments, attachments in both topic emails and reply emails properly uploaded via the mailsave/comment_upload and upload modules, and the inverse of new forum topics and comments/replies being posted to the mailing list, with comment_subscribe properly providing email notices upon new comments/replies being submitted to the forum.

Here are the versions I used for each:
Drupal 6.3 core
Mailhandler 6.x-1.3
Listhandler HEAD from July 30 (still seems to be latest)
Mailsave 6.x-1.2
Comment_Subscribe 6.x-1.1
Comment_Upload 6.x-1.x-dev (2008-Aug-11)

The changes I made were as follows:

- the code was originally calling function _comment_upload_load_files(), but in the comment_upload module for 6.x, the function is comment_upload_load_files() (no leading "_").

- added $fragment as an optional argument to _listhandler_mail_links to add "/comment-" to the URL back to the forum comment being mailed out. Used $fragment in function listhandler_send_mail's call to _listhandler_mail_links.

- reworked _listhandler_mail_links to properly call the url() function of Drupal 6 with the options structure populated with 'absolute' -> TRUE and 'fragment' => the new $fragment argument.

- in listhandler_parent_thread(), set the node's status field as follows, so the comment is published if the permission to post w/out approval is set:

$node->status = user_access('post comments without approval') ? 0 : 1;

CommentFileSizeAuthor
listhandler.module.gz7.95 KBjmhohman

Comments

philipnet’s picture

Assigned: Unassigned » philipnet

Hi jmhohman,

Thanks for the feedback and feature/bug report.

I will get around to testing this and incorporating it as soon as I can.

Regards.

P.

philipnet’s picture

Hi jmhohman,

Just a quick update to say that I've been testing it and have tweaked one thing: I've put speech marks where it's name=$file->filename and filename=$file->filename so that the filename is quoted in the resulting email. This enables filenames with spaces to go through to the email client with the complete filename intact.

Otherwise I hope to commit this in the next few days (or weeks).

P.

scottrigby’s picture

Hi, would you recommend using jmhohman's version in the meantime, until the next commit?

philipnet’s picture

Hi,

Thanks for the prod.
I've committed this to CVS, so tonight the tarball should regenerated and I would recommend using that.

I've also back ported the speech marks to the 5.x branch of Listhandler; an updated tarball of that should also appear tonight.

Please report any problems to the issues queue.


Thanks.

P.

scottrigby’s picture

Great news philipnet - I look forward to testing it out... will report back with any issues :) Scott

philipnet’s picture

Version: master » 6.x-1.0
Status: Needs review » Fixed

This is now in the stable release.

Regards.

P.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.