See the api, first line of this function calls

$filters = node_filters();

$filters is never used in the function. It's not a big deal, but, you know, little things can help :-)

CommentFileSizeAuthor
#1 297391_node_filters.patch563 bytesmr.baileys

Comments

mr.baileys’s picture

Version: 6.4 » 7.x-dev
Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new563 bytes

I think you're right, this is a bug and the call to node_filters is obsolete. Needs to be fixed against 7.x-dev and then backported.

einsicht’s picture

Awesome, thanks! I hope to get involved with Drupal on the code side of things soon (you know, not just file bugs, but help out with fixing :D)

mr.baileys’s picture

Hi einsicht, that would great.

Feel free to assign this issue to yourself and take it from here. Next steps are waiting for a review, incorporating any changes that might be requested during review, and after it gets commited you'll have to roll a new patch for D6.

If you want to dive into the code side of things, take a look at the Quick fixes and the Novice queue as they provide ideal opportunities to get started with some smaller patches.

If you need pointers, make sure to read:

... or ask around in IRC.

einsicht’s picture

Thanks. I'll get started this week, I hope. School quarter's just done now so I should have some time to help out. Can't wait for D7!

dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks Mr. Baileys, also for coaching new developers. Glad to see. Keep up the good work.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.