Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hey, I just made a few changes to the comments, but the main reason for this patch is to change the opening <?PHP tag to enable my text editor to properly colorize the code. Just makes it easier to read as I attempt to help out on this project. :-)
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | privatemsg_cleanup-297419-6.patch | 36.83 KB | litwol |
| #5 | privatemsg_cleanup-297419-5.patch | 37.49 KB | mrtoner |
| #4 | privatemsg_cleanup-297419-4.patch | 23.44 KB | mrtoner |
| #3 | privatemsg_cleanup-297419-3.patch | 22.62 KB | mrtoner |
| #1 | privatemsg_cleanup-297419-1.patch | 26.2 KB | mrtoner |
Comments
Comment #1
mrtoner commentedOkay, this latest patch cleans up the formatting of the module somewhat as I am learning about Drupal coding standards.
Comment #2
litwol commented#1 doesnt apply anymore. Please re-roll after the latest commits to HEAD.
Comment #3
mrtoner commentedRe-rolled against HEAD.
Comment #4
mrtoner commentedHmm. I should have included the edits from #297852: t() not used for hook_menu().
Comment #5
mrtoner commentedInstalled the Coder module and found a bunch more edits I needed to make. Also added a description for the admin page and added some indents for readability.
Comment #6
naheemsays commentedPatch applies cleanly and most changes seem to be sane.
I do have a question about tabbing (with spaces) though... in some places the module uses multiple spaces before an equals so that multiple lines align their equals signs. I on the other hand tend to use just one space - am I in the wrong?
EDIT - another copding convention question - are we following the . convention? I know that it has been changed for Drupal 7 and that some maintainers dislike the version for previous drupal releases, so I would like a clarification on that too.
I would also assume that this is a fragile patch and should probably be merged before others.
Comment #7
mrtoner commentedIt's optional and a matter of personal preference. I like the readability.
This is the first serious contribution to Drupal for me, so I'm not familiar with that?
Comment #8
litwol commentedThis is a big patch. i will review and commit it now. beware that this may (and most likely will) break other patches because this one is so big.
Comment #9
naheemsays commented@ MrToner - prior to Drupal 7 (still in dev), the coding style enforced was that when concatenating two strings, the dot (.) would have a space between itself and any functions/variables, but not between it and quotation marks, giving code like
$x = $y ."stuff";.This was recenly changed to be the same with other projects and have a space on both side, making the above code
$x = $y . "stuff";.Nothing major, but sometimes it makes a difference. reference: #245115: Fix Drupal's awkward coding standards for the . operator
Comment #10
litwol commentedI did few minor style changes to make coder module happy. I'm attaching the patch which was used.
commit details are here: http://drupal.org/cvs?commit=137669
Comment #11
mrtoner commented@nbz: I have always used a space on either side, so I was confused when Coder made its suggestions. I'm for the D7 way.
Comment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.