There are some improvements that can be made to the way trackbacks are displayed. The issues are:

1. Trackback should be displayed adjacent but may not be if there are other node->content[] elements. This is desirable because trackbacks, like comments, are primary feedback mechanisms and should be grouped together.

2. The

title for the trackback URL section is inconistent with the title conventions for all other parts of the node.

The suggested fix for #1 is to adjust the #weight to make trackbacks very heavy, so they sink to the bottom of the content[].

The suggested fix for #2 is to use the title as a title (just "Trackbacks"), and put the additional verbiage into the section.

Please see the attached patch. Also see the attached screenshot, to see how these changes look on my site.

Comments

chip’s picture

Rats, sorry. The literal <h2> in the above is messing up the display.

lomz’s picture

Could it be made to be a part of the links? But just for the full body.
Like in Wordpress

<a href="http://-Trackback-URL" title="URL for Trackbacks">Trackback URL</a>
thepanz’s picture

Version: 6.x-1.1 » 6.x-1.x-dev

@lomz: I added this feature in a my edited Trackback module... I also have integrated some other edits to improve admin-settings... I'll post a patch agains latest 6.x-1.x-dev version soon...

Regards

lomz’s picture

Sounds nice

thepanz’s picture

StatusFileSize
new20.14 KB

Hi, this is my patch with some edits:

- Improved Admin section (added fieldsets)
- Added new Permission to solve #228797: Trackback settings is shown for non-permission-users in add new blog
- Applied patch #299970: bad class "0" on trackback link
- Appied patch #281772: Can't update with Update-Status and CVS-Deploy
- Added feature for #311020: Moving URL to block?

and:

- Trackback URL configurable in several ways (display below post, hide, display in links, display in links for full-node, display in linke for teaser-node)
- Some Doxygen comments added

it's a huge patch, maybe will not be merged into current version... hope to hear about your comments

lomz’s picture

Sounds fantastic, will test.

lomz’s picture

This is great, if this is not added to current it is a scandal.

thepanz’s picture

Please review my patch, list problems and (if none) change Issue status! :)
Regards

lomz’s picture

Status: Needs review » Reviewed & tested by the community

Havent found any bugs

thepanz’s picture

Well! Hope that my (huge) patch will be merged in current version!
Bye!

wretched sinner - saved by grace’s picture

Patch applies with fuzz to 6.x-1.x-dev (2008-May-14)

All seems to be fine working from this end.

@thePanz - webchick has written a great post about 'mega patches' like this - worth a read for explanation as to why the smaller patches are better to test!

thepanz’s picture

Yes wretched, you're right. I posted this huge patch because I worked on all of these features in the same time, and I don't have a progressive patch for each one.
I asked the maintainer if I can help with submitting or co-maintaining this module (you're right: no commits in 21 weeks is a long time), but no responses. Also another co-maintainer asked Ankur (module owner) to let me in, but no replies received. Maybe you can ask Ankur too..

Regards

ps: is the patch working fine? What do you mean "with fuzz"? Let me know!

wretched sinner - saved by grace’s picture

Fuzz means that it can patch the file, but there was a little something wrong with the context area of the patch. See http://www.delorie.com/gnu/docs/patch/patch.man.html for more info.

As you have obviously seen, I have filed a request to see if it is actively maintained, as per the procedures at http://drupal.org/node/251466. Maybe you might want to post in #337142: Is Trackback still being maintained? that you would be happy to take over the project. If we don't hear from Ankur within 2 weeks, we can forward the request onto the appropriate area to get the maintainer changed.

thepanz’s picture

Status: Reviewed & tested by the community » Fixed

Committed into latest 6.x-1.x-dev version

thepanz’s picture

Status: Fixed » Patch (to be ported)
seanr’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev

I could really use this in D5.

thepanz’s picture

@seanr: I don't have any D5 test-site, could you provide a patch for D5 release? I think it's not an hard task..
Regards

nquocbao’s picture

I found an other problem when I try to apply theme to trackback:

The trackback_link hook doesn't use any index-key for $links, so the trackback link in $links array is a number, then it's make theming impossible.

function trackback_link($type, $node = NULL, $teaser = FALSE) {
// ...
     $links[] = array(
// ...
}

should be

function trackback_link($type, $node = NULL, $teaser = FALSE) {
// ...
     $links['trackbacks'] = array(
// ...
}

If we assign a key for link, we can use css class to apply theme to trackback link (icon for example)

thepanz’s picture

@nquocbao: are you using latest 6.x-dev version? In 6.x your issue should be fixed.

Regards

nquocbao’s picture

I'm using 1.1

Thanks for your reply

thepanz’s picture

@nquocbao: try the 6.x-1.2 release: it has few enhancements and some bug-fixes from 1.1
If you are on 5.x branch all of these edits have to be ported from 6.x

Cheers

TheInspector’s picture

The #1 patch doesn't seem to work in the 6.x-1.2 version. Does anybody know how to get this working with the latest version? That would be really nice!

thepanz’s picture

@TheInspector: the 6.x-1.2 release already have the latest patches (#1 and #6).

This thread is "open" and "to be ported" only to let someone post a 5.x patch with the above (and merged into 6.x branch) edits.

Cheers

pomliane’s picture

Status: Patch (to be ported) » Closed (won't fix)

This version of TrackBack is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.