It appears that the Etc/GMT labels in the event_get_timezones() function in event_timezones.inc is the wrong way around. For example, Etc/GMT-10 should be Etc/GMT+10.

The way the event_timezone_map($offset) function is coded means that it is easier to change the timezone labels rather than the offsets.

I have attached a patch, which corrects all the Etc/GMT entries apart from Etc/GMT+0.

CommentFileSizeAuthor
#5 event_timezones.inc_HEAD_0.patch8.17 KBdrewish
#4 event_timezones.inc_HEAD.patch2 bytesdrewish
#2 event_timezones_fix.patch8.04 KBkmo
event_timezones.inc.patch8.05 KBkmo

Comments

Tobias Maier’s picture

Tobias Maier commented

patch file looks broken for me...

kmo’s picture

kmo commented
StatusFileSize
new event_timezones_fix.patch8.04 KB

Let's try again

frjo’s picture

frjo commented

I found this bug my self and have fixed it in the same way as this patch do. This should be commited to both 4.6 and cvs.

drewish’s picture

drewish commented
StatusFileSize
new event_timezones.inc_HEAD.patch2 bytes

I couldn't get that patch to apply either, I didn't look like it was done against CVS. I did it by hand and rolled a new patch. It should apply to both 4.6 and HEAD (though you might have to tweak the version id).

drewish’s picture

drewish commented
StatusFileSize
new event_timezones.inc_HEAD_0.patch8.17 KB

I'll try this whole "attaching" thing again...

crunchywelch’s picture

crunchywelch commented

committed to cvs and 4.6

crunchywelch’s picture

crunchywelch commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
Cromicon’s picture

Cromicon commented
Version: » 4.6.x-1.x-dev

GMT user
US server
Times on event calendar change as described above.
Site installed 1 week ago from latest update.
Is it possible the code has been accidentally reverted?