Every time I go to edit the entry-type, I see that the appearance-field is empty, but it works, maybe it should be made able to remember?

CommentFileSizeAuthor
#1 submitted_by_1.patch779 bytesnancydru

Comments

nancydru’s picture

Status: Active » Needs review
StatusFileSize
new779 bytes

This should fix it.

nancydru’s picture

Assigned: Unassigned » nancydru
Status: Needs review » Fixed

Committed.

bonobo’s picture

Version: 6.x-1.0 » 6.x-1.x-dev
Status: Fixed » Active

Seeing this issue on both the dev version (that has this patch applied) and using 6.x-1.0

Using CCK 6.x-2.0-rc10 and Token 6.x-1.11; Drupal core 6.6

nancydru’s picture

Title: Doesnt remember the submitted settings » Doesn't remember the submitted settings
Status: Active » Postponed (maintainer needs more info)

This is strange; it works fine for me. Could you tell me what pattern you have, please? Are you sure you don't accidentally have an older version that is being used somehow?

bonobo’s picture

Yup, I'm using the dev version of the module, and, fwiw, I've cleared all the cache tables in the db and the browser cache on the off-chance that something had been cached that was affecting what I was seeing.

On node creation, the pattern does not get used.

For testing purposes, I kept the replacement pattern simple: [yyyy]

Also, I'm very open to the possibility that this is a PEBKAC -- but I have yet to discover the obvious thing I'm overlooking. This module appears admirably straightforward: install submitted_by and token, and then enter the replacement pattern for different content types. Is there a step I'm missing?

nancydru’s picture

I'm baffled. Yes, this module is that simple.

Cologner875’s picture

Version: 6.x-1.x-dev » 6.x-1.1

After updating to version 6.x-1.1, this issue is not fixed, the module does not remember the content of 'Submitted by...' text. Perhaps I should mention that it did remember the content using Version 1.0 :) It would be great if that could finally be solved.

I'm using the module with Drupal 6.9 and Token 6.x-1.11, my webbrowser is Firefox 3.05 if that is important.

nancydru’s picture

Can you tell me what other modules you have - especially if any were added after version 1.0.

Cologner875’s picture

Status: Postponed (maintainer needs more info) » Active

i only updated Submitted By, the other modules did not change. here are the modules, that are also displayed in the content-type edit-settings:

- Filter by node type 6.x-1.2
- Scheduler 6.x-1.3
- Diff 6.x-2.0
- Composite Layout 6.x-1.0-beta6
- Content Construction Kit (CCK) 6.x-2.1
- Content Access 6.x-1.0

-Administration menu 6.x-1.3 is always on top of the admin pages

I hope this helps to replicate it.

sourabh.iitm’s picture

Even i am facing this problem with version drupal 6.9 & submitted by 6.x-1.1. Every time i am trying to edit the content type, Submitted by field is empty. So saving any changes restores default settings.

I didn't had any previous version of this module. I have installed 6.x-1.1 so there is no update involved.

fheinley’s picture

I had the same problem with drupal 6.9 & submitted by 6.x-1.1 - when I looked, the values were getting saved, but the node editing form wasn't reading them back in.
I have changed the submitted_by.module file, line 68 (function submitted_by_form_node_type_form_alter)
from: $type = isset($form['identity']['type']) ? $form['identity']['type']['#value'] : '';
to: $type = isset($form['#node_type']->type) ? $form['#node_type']->type : '';
This has fixed it for me. Not sure how correct this is, but its working for me.

nancydru’s picture

Thank you very much, Frank. I have committed this fix. I also took the opportunity to alter the fieldset title and expand the fieldset when a value exists.

It is very interesting: When I started looking at this, I chose "story" and it was indeed experiencing this problem. But the types that I had been using for testing were not. I wonder why some types had that value and some did not?

nancydru’s picture

Status: Active » Fixed
sourabh.iitm’s picture

Thanks a lot. Development version is working for me too.

nancydru’s picture

Thanks for the update.

Cologner875’s picture

Thanks for the bugfix! What about making the curent dev version a stable release? :)

It would perhaps only contain this bugfix, but it improves usability a lot, also for users, who do not read the issues (and therefore would not install the dev version).

nancydru’s picture

Status: Fixed » Closed (fixed)

I don't normally like to create new releases more than once a month, but I did anyway.