Add xpath method to Simpletest and refactor existing tests
boombatower - August 20, 2008 - 23:00
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | critical |
| Assigned: | boombatower |
| Status: | closed |
Description
A number of tests and internal functions use xpath to make assertions. This is a very powerful feature, but is not documented or exposed in any way.
This patch adds an xpath method to DrupalWebTestCase so that it can be both documented, used consistently, and enclosed in the proper $this->parse() condition.
The patch also reactors existing tests and internal code that uses xpath. Changing $this->elements->xpath(...) becomes $this->xpath(...).
I have not tested this patch and will get back to it, but I have to leave at the moment so I figured I would post what I have.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simpletest_xpath.patch | 6.34 KB | Ignored | None | None |
#1
Making some changes.
#2
Just needed
$this->elements->xpath()instead of$this->xpath()(recursion heh).#3
This patch is required for: #297894: Add assertLink and assertNoLink to SimpleTest
which is required for: #296693: Empty admin categories are not hidden
which is required for: #263616: Move SimpleTest out of "Site building"
So I'll mark it as critical.
#4
Ran tests on changed/effected code and they all pass except two with exception. If someone wants to run on all tests that would be great.
SimpleTest functionality: 43 passes, 0 fails, 2 exceptions
Drupal HTTP request: 4 passes, 0 fails, 2 exceptions
#5
This should fix the exception mentioned. Still need whole suite to be run.
#6
Ran entire test suite with all passes.
#7
Code looks good to me. Since the test suite still runs to 100% perfecton, this is RTBC.
#8
#9
Committed to CVS HEAD. Thanks.
#10
Automatically closed -- issue fixed for two weeks with no activity.