Dmitri, you're @$%&@ awesome! This is so great I just about cried.

Some bugs:

  • PHP error 'Ilegal offset' on common.inc line 777 on admin/settings/main, see screenshot
  • It is not color module compatible. See screenshot of the module on drupal.geek.nz (Garland theme, Belgian Chocolate color set). Separate the CSS into core-worthy (generic, grey) and theme-worthy (colored blue, for garland). Later we'll need to add the theme CSS to each and every core theme and tweak the colors to fit the particular theme or be color.module-compatible in the case of Garland. This is approximately equivalant or duplicate of an issue on nodeform's issue queue
  • admin/settings/main is not added to the menu. I assume this is intentional given the stage of development.
  • Some drawers in admin/settings/main have one fieldset containing all of the fields, so the fieldset is redundant. See the screenshot.

There is a serious usability bug on admin/settings/main, in that the button is not above the fold. In the screenshot it is only visible because I have a 30-inch monitor.

This is not an issue on the node forms for two reasons; the drawers are part of a larger form, and the contents of the largest drawer is (usually) small.

I'm not sure what the best fix is but I have a few ideas;

  • Move the buttons to be in the left column just below the last tab. See annotations on screenshot. This needs to be done with some tricky CSS (and javascript?) so that the buttons 'fall' vertically into the gap if there is a gap, but stay below the drawers horizontally aligned if there isn't vertical room for them below the drawers. Button text may need to wrap.

    I can help with the CSS for this if you're not sure how to do this in CSS. I'm not sure that it's possible with CSS alone and may require some JS.

  • Have a copy of the buttons ABOVE the form, or at the bottom of the inside of each drawer. This would need to be done by the caller of the vertical tabs element renderer (or at least a boolean flag set by the caller), since vertical tabs can't abstractly determine whether additional duplicate form buttons are appropriate or not.

In regards to duplication of efforts, don't wait for ximo. I believe nodeform was created as a working prototype, not core-ready.

CommentFileSizeAuthor
#1 Main configuration | Bevan Rudge-3.png458.23 KBBevan

Comments

Bevan’s picture

StatusFileSize
new458.23 KB

The screenshot

dmitrig01’s picture

On the settings form was only for fun, i'm probably going to remove that. I also agree about the "standard" vs. garland - it also doesn't work with *any* other theme ATM.

quicksketch’s picture

Status: Active » Fixed

I'll mark this as fixed, since at least 3/4 the problems reported here are now fixed. Vertical tabs works with other themes now, and the admin settings page has been removed entirely. Feel free to open up new issues for any individual problems the module still has. Thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.