Works perfectly with login, bot not showing up as Teaser or Full node...

CommentFileSizeAuthor
#13 thickbox_imagecache.patch1.01 KBmelon

Comments

frjo’s picture

Status: Active » Postponed (maintainer needs more info)

This one I think you need to explain som more. What is it you are trying to do? What methods have you tried?

nchase’s picture

same problem here. The login works but one I set the thickbox up for content types, like blog and then change the display to thickbox:imagecache all the images disapear... it's probably not imagecache as without thickbox the images are displayed.

schlotterich’s picture

I have the same problem! When I upload the pictures on a Blog or any other Content Type and use the Thickbox I can't see them anymore. Without Thickbox everything works fine.

frjo’s picture

Are you using imagefield + imagecache? Something else? What versions of the modules and of Drupal?

When you write so terse as you do above it's very difficult to help you. Put some effort in to your questions and I will put some effort in to the answers.

clown10’s picture

The same here. I use Drupal 6.4, imagecache and imagefield latest versions.Do I maybe need a other version of jquery than the one that ships with drupal 6.4?

binford2k’s picture

Drupal 6.4, latest versions of thickbox, imagecache, imagefield, cck.

I create an image cache profile (call it thumb). I create a content type, add an image field to it. In display settings for that type, I select to display it as 'Thickbox: thumb'.

Result: that field doesn't display at all.

frjo’s picture

Assigned: Unassigned » frjo
Category: support » bug
Status: Postponed (maintainer needs more info) » Fixed

Thanks binford2k, now I understand the problem and I can also recreate it. I have still not updated my own sites to Drupal 6 so I need good bugreports to be able to fix stuff in Drupal 6.

I had some time between sessions here at Drupalcon in Szeged :-) and have just committed a update that seems to work on my local install.

Please report back here after you have tested.

binford2k’s picture

No change.

frjo’s picture

Status: Fixed » Postponed (maintainer needs more info)

Make sure you have "thickbox.module,v 1.18.2.7", you find it at the top of the thickbox.module file.

You may need to redo the "Display settings" at admin/content/types for the node types you want Thickbox to be active for.

Also check that you don't have any other JavaScript that interfere with Thickbox.

archnode’s picture

I use the new version of the thickbox module, but the module uses the wrong imagecache preset. I set it to "thickbox - image_thumb", but it still uses "image", a preset i used in a previous setup (In the display setting it shows the right setting).

binford2k’s picture

// $Id: thickbox.module,v 1.18.2.7 2008/09/03 06:04:50 frjo Exp $

I reset display settings and the imagecache profile. It doesn't have anything to do with javascript. The problem isn't that thickbox fails to pop up, it's that NOTHING is printed. It doesn't even print the usual div wrappers around the field.

melon’s picture

I peeked the code and it seems that thickbox_field_formatter() isn't getting the expected value for $namespace and thus if ($preset = imagecache_preset_by_name($namespace)) never turns out to be true, the appropriate theme() function never runs.

melon’s picture

Status: Postponed (maintainer needs more info) » Needs work
StatusFileSize
new1.01 KB

I hacked around a little bit, and made this work. I used imagecache alpha2.
With this patch it renders the proper fields with the selected preset. I found that the problem was mostly because of the use of incorrect variables.

To be honest, this is an ugly, quick and dirty fix. I haven't looked into the entire module and this patch might break some other stuff, or even eat up your cat. But it might give directions to the maintainers.

frjo’s picture

The patch in #13 should not be necessary.

Please try to deactivate/activate the module and see it that fixes this issue.

Make also sure that the "Display settings" at admin/content/types are set correctly for the node types you want Thickbox to be active for. During development I noticed that I sometimes had to redo these settings.

melon’s picture

I tried it all, but without the patch the html output doesn't contain any image field divs.
I also set up a clean install to test it and still didn't work unpatched.
Versions used:

  • Drupal 6.4
  • CCK 6.x-2.0-rc6
  • Filefield 6.x-3.0-alpha4
  • Imagefield 6.x-3.0-alpha2
  • Imageapi 6.x-1.0-alpha2
  • Imagecache 6.x-1.0-alpha2
  • Imageapi 6.x-1.0-alpha2
binford2k’s picture

deactivated/uninstalled/reactivated/redid all display settings -> nothing
applied patch #13 -> works

Thanks.

daniel-san’s picture

I'll add that on my devel site, locally working with MAMP, the Thickbox 6.x-1.x-dev (2008-Sep-06) module is working perfectly. Created new site on my server with all the same modules and setup and Thickbox is causing the same issues as stated above. The imagecache created thumbnails will not show up if I choose to have Thickbox->thumbnails in the full node.

Using:
Drupal 6.4
Imagecache 6.x-1.0-alpha2
ImageAPI 6.x-1.0-alpha2
ImageField 6.x-3.0-alpha2
Thickbox 6.x-1.x-dev (2008-Sep-06)

The available updates page on both local dev version and hosted site are the same as of Sept. 9, 2008 1:21pm Pacific time.

Dan

**UPDATE***
Hope this helps us solve this issue. Just disabled Thickbox and enabled Lightbox2 and the same thing occurred. Chose to use Lightbox on the Full node and the image thumbnails would not appear. Could it be and imagecache or imagefield problem?

Also, noticed that my hosting service has the database at MySQL 4.1.22 and my localhost/MAMP install is using 5.0.41. As of right now, that is the only noticeable difference between the two sites that I have found. I have unistalled Thickbox, dropped any leftover tables, reinstalled Thickbox, created new image fields on content type and still the same problem with the thumbnails not showing up when Thickbox enabled on the display for Full Node.

daniel-san’s picture

After working for several hours to try and figure this out, I finally applied the patch in #13 given by melon and thickbox worked instantly.

frjo’s picture

Can it be that all you who have this problem has named your Imagecache preset with a underscore?

I just committed a new version to 6-dev, v 1.18.2.9, that changes the formater delimiter from _ to ][ to take care of this conflict. Underscores are perfectly alright in preset names.

binford2k’s picture

Haha. Yes, my presets have underscores.

daniel-san’s picture

I just checked mine and I did use an underscore for my content type. I used photo_album. I will test your new version later tonight and update.

Interestingly, I used underscores on my localhost/MAMP version and it worked perfectly without this update or patch.

daniel-san’s picture

Your update works. I made sure to completely uninstall the Thickbox version that had the applied patch from comment #13 and then used your Sept 10 updated version. Worked great and matter of fact it seems to cycle through the images quicker than previously with the patched version, as well as quicker than my local dev site that happened to work with the earlier version of Thickbox.

Great job and really appreciate your work on the module.

Take care,
Dan

melon’s picture

Status: Needs work » Fixed

Thanks, frjo this finally works great.
I didn't looked into the code deep enough when I made the patch in #13 and this fix has significantly better logic than mine. Thanks for dealing with the problem. After all, using underscores in a preset is quite common so I'm glad this is fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.