5.x Port + Code Update [#298079]

Hello Allie,

As Chris mentioned in this issue (http://drupal.org/node/292761), we've done some considerable work in order to get QB integration for an ubercart site using this module as a base. I'll be adding a separate project for the Ubercart part, but both together is currently working fairly well for our needs.

The site we built it for is a 5.x site however, so this patch is actually a 5.x port + an update at the same time. There really isn't much differences though between the 5.x and 6.x functionality I believe so it would not be difficult to port back up to 6.x. I'll take a look later and maybe post a separate patch.

Could you look over the direction that this patch takes and see if it makes sense to you and a way you'd like to proceed with it? I will post a link to the Ubercart integration module when I get that setup.

I'd also like to thank you for the initial code base which provided a very good start for getting into the Web Connector stuff and doing the Ubercart integration!

Thanks!

PS: If you would like I could also co-maintain the module to help with bug fixes and updates. Would of course need to see the direction the code takes first :)

Comment	File	Size	Author
#14	qb.rar_.gz	123.96 KB	kirikintha
#12	uc_qb.tar_.gz	37.51 KB	redhatmatt
#6	qb.port_.5x.patch	7.09 KB	sarvab
#6	qb.update.5x.patch	35.12 KB	sarvab
	qb.patch	37.55 KB	sarvab

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sarvab CreditAttribution: sarvab commented 21 August 2008 at 12:33

Here is the Ubercart module: http://drupal.org/project/uc_qb

Comment #2

Allie Micka

she/her

CreditAttribution: Allie Micka commented 21 August 2008 at 23:47

ROCK!

For a minute, I thought the uc_qb project was a parallel effort, and now I'm just pleased as punch that it's not! :)

At the moment, I don't have time to look into this. But I assume you made some basic changes to get this functional ( applicable to both 5x and 6x ), and you - obviously - made changes to backport it.

Is it possible for you to submit a patch for the former so we can identify what works? Offhand, I presume that most of the code that does real work is common between the two versions.

Thanks again!

Comment #3

sarvab CreditAttribution: sarvab commented 22 August 2008 at 07:18

Hello Allie,

Thanks for the response :)

Your right that the bulk of the changes are really the same between both 5.x and 6.x. I'd be glad to upload a plain 6.x -> 5.x patch and then separate 5.x -> update and 6.x -> update patches to make things a little bit easier to see what is going on.

I'll most likely be able to do that over the weekend, so in the next day or two.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 22 August 2008 at 20:33

I just tried to apply the patch, it threw a bunch of errors:

~/sites/all/modules/qb
$ patch < qb.patch
patching file qb.patch
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file qb.patch.rej
patching file qbwc.inc
patching file qbwc.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file qbwc.info.rej
patching file qbwc.install
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file qbwc.install.rej
patching file qbwc.module
patching file qbwc.wsdl

Comment #5

sarvab CreditAttribution: sarvab commented 2 September 2008 at 05:20

It seems it added a section at the top of the patch for patching the patch file itself for some odd reason, but when it says "Apply anyway?" if you say Y there it should work fine. I believe you may have hit N there and it should be saying "SKIPPING" instead of "FAILED" in the various sections below it.

Comment #6

sarvab CreditAttribution: sarvab commented 2 September 2008 at 07:21

File	Size
qb.update.5x.patch	35.12 KB
qb.port_.5x.patch	7.09 KB

Here are two separate patches for the port to 5.x and then the update in functionality. I'm going to make a separate issue for the update in functionality for 6.x.

Comment #7

RikiB CreditAttribution: RikiB commented 31 January 2009 at 07:32

Version:

» 6.x-1.x-dev

Hello, Im having a really hard time patching these files succesfully. Could anyone please post a link to the already patched files? Im getting hunk failed errors everywhere.

$ patch -p0 < qb.port_.5x.patch
patching file ./qb.inc
Hunk #1 succeeded at 7 with fuzz 1 (offset 6 lines).
patching file ./qb.info
Hunk #1 succeeded at 1 with fuzz 2.
patching file ./qb.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ./qb.module.rej
patching file ./qbwc.inc
Hunk #1 FAILED at 21.
Hunk #2 FAILED at 35.
2 out of 2 hunks FAILED -- saving rejects to file ./qbwc.inc.rej
patching file ./qbwc.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ./qbwc.info.rej
patching file ./qbwc.install
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ./qbwc.install.rej
patching file ./qbwc.module
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 29 with fuzz 1 (offset 2 lines).
1 out of 2 hunks FAILED -- saving rejects to file ./qbwc.module.rej

$ patch -p0 < qb.update.5x.patch
patching file ./qb.module
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 20.
Hunk #3 FAILED at 30.
3 out of 3 hunks FAILED -- saving rejects to file ./qb.module.rej
patching file ./qbwc.inc
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 40.
Hunk #3 FAILED at 76.
Hunk #4 FAILED at 93.
Hunk #5 FAILED at 234.
5 out of 5 hunks FAILED -- saving rejects to file ./qbwc.inc.rej
patching file ./qbwc.install
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ./qbwc.install.rej
patching file ./qbwc.module
Hunk #1 FAILED at 9.
Hunk #2 FAILED at 18.
Hunk #3 FAILED at 35.
Hunk #4 FAILED at 106.
4 out of 4 hunks FAILED -- saving rejects to file ./qbwc.module.rej
The next patch would create the file ./qbwc.wsdl,
which already exists!  Assume -R? [n] y
patching file ./qbwc.wsdl

Thanks!
- Riki

Comment #8

redhatmatt CreditAttribution: redhatmatt commented 18 February 2009 at 06:04

Would really appreciate a uc_qb module/zip file for d6_uc2... please?
Thanks!

Comment #9

redhatmatt CreditAttribution: redhatmatt commented 22 February 2009 at 03:21

My patch has not been working out, perhaps it's because of it being a uc_ module vs. a straight d5 to d6 conversion, as I have read howto take a module from 5 to 6. Hoping you will post a 6x version of uc_qb. Thanks

Comment #10

redhatmatt CreditAttribution: redhatmatt commented 24 February 2009 at 23:31

so i gave up on the uc_qb on 6x... and tried patching these files to 5... the order of the files is all messed up in the qb api as far as how the patch says the order should be.

To echo Riki... can we please have a link to the already patched files.

Thank you

Comment #11

redhatmatt CreditAttribution: redhatmatt commented 25 February 2009 at 00:50

Or can you provide an older version of this API module(s) that worked at the time when when this patch was written? Dove down the cvs to find the release around that time but all scattered.

Comment #12

redhatmatt CreditAttribution: redhatmatt commented 6 March 2009 at 19:27

File	Size
uc_qb.tar_.gz	37.51 KB

Here is what I and some others were after, I am sure this will be a total lifesaver for those that are trying to get a solution for themselves or their clients.

Yes, I know I am enabling a situation where no one may upkeep the uc_qb and QB API project as far as a working, up to date project in itself. I am hoping that if this does happen, that it also includes a version 6.

This is for 5X ONLY.

Just to let you know Sarvab contacted me and gave me this so he deserves the credit....

Hello Matt,

Sorry I haven't been able to follow, keep up with the issues there, but I'd be happy to give you the modules as I have them and as they are working for me.

I'm attaching an archive that includes both the qb module and uc_qb module as I have them on our production site. This does not include any of the recent changes to the qb module which maybe is why there is an issue patching them.... There are also a few updates to the uc_qb module here that may not be in drupal cvs.

In terms of the ubercart integration though it should work well.

Regards,
-Sarva

Comment #13

RikiB CreditAttribution: RikiB commented 11 March 2009 at 23:07

Thanks!

Comment #14

kirikintha CreditAttribution: kirikintha commented 25 March 2009 at 15:08

File	Size
qb.rar_.gz	123.96 KB

I had a few bugs, here is an updated version, not "updated" with the new 6.x dev code, but what was uploaded earlier. This is seriously awesome! I love it thank you to all who worked on this.

BTW - you have to set the configuration settings first, then download the file .qwc to your appropriate directory.

Thanks again - this saved my life!

Comment #15

MrDruPaul CreditAttribution: MrDruPaul commented 9 July 2009 at 15:03

Hi there. This looks like a great feature. Any chance of it being updated to version 6? Thanks

Comment #16

Allie Micka

she/her

CreditAttribution: Allie Micka commented 9 July 2009 at 15:15

The functionality provided by this patch was incorporated into the D6 branch prior to some reworking/updates. The uc_qb module will need to be updated accordingly.

Thanks!

Comment #17

haysuess CreditAttribution: haysuess commented 25 September 2009 at 17:40

Hey...I am running a Drupal 5.x and Ubercart 1.x site and am trying to figure out a QuickBooks integration. It looks like from what I'm reading here that I need the 5.x-1.x-uc_qb module, and a patch or port for another qb module(quickbooks API)? I have the necessary uc_qb module, but which of the links in this post (or elsewhere) do I download the correct 5.x QB API file from? Any help would be appreciated, thanks.