Hi,

On line 1620 of faq.module it says; 

$header .= "<$hdr>\n";

I think this should be;

$header .= "</$hdr>\n";

That way closing the h5 or h6 tag!

Cheers

Comments

stella’s picture

stella commented
Status: Active » Closed (won't fix)

This is not an issue in the 5.x-2.11 release nor the latest dev release. The closing tag is correct and the / is present.

Cheers,
Stella

bartezz’s picture

bartezz commented

Sorry Stella,

I've just downloaded the source again and indeed it isn't an issue there. Has it been before tho? I kept the original zip files of all my module downloads and it was an issue in there. Maybe I've been messing things up then :)

Sorry to have wasted your time!

Cheers

stella’s picture

stella commented

I think there was a missing closing div tag once, in the D6 version, but I don't recall a missing hdr one. It could have been from an intermediate dev version perhaps? Anyway, it's there in the code, so no problems here :)

Cheers,
Stella

bartezz’s picture

bartezz commented

Hey Stella,

I found the problem and it's a freaking weird one!!!!!

I'm using Dreamweaver CS3 version 9 build 3481 on XP pro SP 2 for editing and it's Dreamwaver that's causing it.
When I edit the code and save the document all looks fine, when I close the document and re-open it in notepad it still looks fine.

Yet when I re-open it in Dreamweaver the code somehow is filtered and the closing tags is altered;

$header .= "</$hdr>\n";

becomes

$header .= "<$hdr>\n";

So now I've changed it to

$header .= "</".$hdr.">\n";

I haven't tested it on other systems with this software setup so I don't know if it's the configuration or Dreamweaver.

Cheers,
Bart

stella’s picture

stella commented

I'd imagine it's Dreamweaver. I've never come across that before! Thanks for letting us know.

I've added in the above change so you won't have to modify the module in future.

Cheers,
Stella

stella’s picture

stella commented

Released in 5.x-2.12.

bartezz’s picture

bartezz commented

Cool :)