The new line character "\n" in the following line

$output .= "</li>\n";

was adding unwanted whitespace which made the mouse-overs look just a hair off,
makes the html code more readable but not useful when tightly spaced buttons are needed.

Comments

dvessel’s picture

dvessel commented
Status: Active » Closed (works as designed)

It's needed for RTL languages. Without it, it doesn't allow it to flow properly.

benmirkhah’s picture

benmirkhah commented

How about testing for that?

$output .= "< /li >".( isRTL ? "\n" : null);

Since over the net RTL is used less often than neatly flushed menus, just a thought...

benmirkhah’s picture

benmirkhah commented
Status: Closed (works as designed) » Active

Switched the status to active since the RTL explanation doesn't outweigh the general annoyance of this bug which can be simply fixed with an if statement checking for RTL...

Patched 3 systems with this issue last week so pardon my impatience =)

dvessel’s picture

dvessel commented
Status: Active » Closed (won't fix)

I'm sorry but theme_links is run quite often so the overhead is not worth it. I did a quick test for a bare test site with 10 nodes loading the front page and that condition would be run over 76 times. Sites with a lot of blocks would increase that even further. It's also used for primary/secondary links.

Have you experimented with CSS? Using display:block and floating the elements should remove any white space.

benmirkhah’s picture

benmirkhah commented
Status: Closed (won't fix) » Closed (fixed)

Thanks for taking that time to test it, your CSS suggestion fixed the problem, our theme had display set as inline...

Status closed