.info file broken and DRUPAL-5 contains module_exist(), a 4.7 function
frjo - August 22, 2008 - 09:56
| Project: | OG Block Visibility |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | paulbooker |
| Status: | closed |
Description
The 5.1.1 release included og_block_visibility.module,v 1.13 where module_exists() (with a s) is used.
The 5.1.2 release reverts to og_block_visibility.module,v 1.12 where module_exist() (no s on the end) is used.
I believe this is a show stopper bug so I set it to critical. The module will not work and your site may even crash.
#1
The info-file also still contains non unix line ending.
#2
Ok, looking at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/og_block_vi...
It appears Paul made the fix of changing module_exist to module_exists() in HEAD, but not in DRUPAL-5. And then he released 5.x-1.1 from HEAD. Then made a change to DRUPAL-5's .info file and released 5.x-1.2 from DRUPAL-5. And thus we got a broken release.
The .info file contains a mixture of line endings: some Mac, some unix. So when the packaging scripts append its info to that file, its completely foobar. The .info should only contain unix line endings to be compatible with the packaging scripts.
Here's patches for HEAD, DRUPAL-5, and DRUPAL-6--1. I'm ignoring the other DRUPAL6--x branches since there's no reason they should even exist at this point. The DRUPAL-6--1 .info isn't actually broken, but I'm submitting a patch for it to make it consistent with the
; $Id$I added to the other 2 versions of the file.The patch for DRUPAL-5 contains the module_exists() fix as well as the .info fix.
#3
Thanks for everything here , really appreciated
I just need to sort out how HEAD .
#4
Automatically closed -- issue fixed for two weeks with no activity.