Currently the rendering of ad_image ads is hardcoded. This patch introduces two new theme functions: one for the ad, and a second for the ad image itself.

This opens the way to the use of imagecache to render advertisements, a possible solution to #232203: Integrate ad_image with imagecache (see my comment there).

CommentFileSizeAuthor
#6 298608.patch3.12 KBBevan
ad_image_theme_patch.txt3.24 KBmleicester

Comments

mleicester’s picture

mleicester commented
Status: Active » Needs review
delykj’s picture

delykj commented

Thanks for the patch, works great.

jeremy’s picture

jeremy commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed

Thanks for the patch. I have merged a variation of it in the 6.x-1.x-dev branch. I will not be back porting this to the 5.x-1.x-dev branch.

I updated the patch to make links and attributes work properly, and applied it to all ad types, not just images. Thus, text ads, HTML ads and external ads are now all displayed through themeable functions. This will be part of the 6.x-1.1 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Bevan’s picture

Bevan commented
Version: 6.x-1.x-dev » 5.x-1.x-dev

Here's a rerolled Drupal 5 patch for other's use if the wish. I understand 5 is not being maintained.

Bevan’s picture

Bevan commented
StatusFileSize
new 298608.patch3.12 KB