_menu_translate returns FALSE before to_arg is available

I might put this line inside the if{} :

+  $map = $path_map;

thought I don't think it will actually have any logical effect.

chx says there might be a problem here - if a to_arg function needs the loaded object. I'm not sure the API for to_arg encompasses that?

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

follow up to #2 - looking at the other function that calls _menu_link_map_translate():

http://api.drupal.org/api/function/_menu_link_translate/6

It's clear that we never expect $map to have the loaded objects when computing the to_arg values, only the path elements.

to re-phrase:

2 functions call _menu_link_map_translate()

the expressed concern recorded in #2 was that the proposed change to _menu_translate would mean that $map would not contain any loaded objects.

In fact, based on the code is _menu_link_translate, clearly the to_arg fucntion should not be expecting to have any loaded objects, and the change proposed here would actually increase the consistency of the code.

per talk w/ Dries, we can jsut do:

if ($to_arg) {
  _menu_link_map_translate($map, $router_item['to_arg_functions']);
}
$path_map = $map;

Here's an additional assertion for the tracker test which demonstrates the bug.

test + fix.

patch for D6

Thanks Peter. Looks good, tests pass so I committed it to DRUPAL-6 and CVS HEAD.

Removing tag on backport.