Making patches to this module is difficult because the source files have regions of CRLF line endings. These should all be LF only, yes?

Comments

mh86’s picture

mh86 commented

It's possible that there are some CRLF in the files, because when I initially started with this project, I was using Eclipse on Windows.
Do you know how I can detect the CRLF line endings and convert it to LF?

Anonymous’s picture

Anonymous (not verified) commented

any dos2unix type of program will do it. i just tried dos2unix from macports, and it fixed the CRLF sections and did not mess up the LF sections.

mh86’s picture

mh86 commented
Status: Active » Fixed

thanks!
I was using dos2unix and committed the changes. I hope it's working now so that we can concentrate on the patches :-)

Anonymous’s picture

Anonymous (not verified) commented

There is still one CR before the function declaration for taxonomy_manager_menu(). But this shouldn't be a problem for the patches I'm submitting over at #298601: reduce complexity and uniqueness of HTML and CSS in this module.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.