I will be adding flash video's to my popup window. The current setting for the width and height of the popup window is too small to fit my video so my users will have to enlarge the window every time they want to view the video. This patch will allow you to set the width and height of the popup window when you perform the theme call.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | popup_width_height_5.patch | 2.92 KB | redndahead |
| #8 | popup_width_height_4.patch | 2.92 KB | redndahead |
| #7 | popup_width_height_3.patch | 2.92 KB | redndahead |
| #6 | popup_width_height_2.patch | 3.09 KB | redndahead |
| popup_width_height.patch | 1.51 KB | redndahead |
Comments
Comment #1
redndahead commentedComment #2
merlinofchaos commentedI'd prefer that this came from the topic itself, so that any invocation of the theme function will check the topic to see if it wants a bigger popup. Obviously this won't help so much if you start at a smaller popup and then navigate TO your help file, but it requires much less work on the part of the module developer. It should be pretty easy to add that as an option to the .ini file.
Comment #3
merlinofchaos commentedComment #4
redndahead commentedBefore I add the corrected patch do you like popup_width and popup_height for the values or just width and height? I like adding popup in front just in case another width and height value is needed.
Comment #5
redndahead commentedehr I mean "popup width" and "popup height"
Comment #6
redndahead commentedI decided to use popup width. Attached is the patch.
Comment #7
redndahead commentedFixing the ini help file to not include width height example.
Comment #8
redndahead commentedHad underscores in a couple of arrays where they shouldn't be.
Comment #9
redndahead commentedOy copy paste stupidity.
Comment #10
merlinofchaos commentedCommitted! Thanks for the patch!
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.