Posted by catch on August 23, 2008 at 8:38pm
6 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | book.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Tests needed for:
Updating book node types.
Setting another node type to be a book page type.
Comments
#1
Heres a stab at this...
patch does the following:
* checks editing of book nodes. These edits modify the book structure
* adds an additional content type as a book page type, checks to ensure it can add this content type to the book outline
* checks the addition of a content type as the default book child page type
#2
@beeradb: I also have a patch that could be quite similar in #299136: TestingParty08: Deleting and editing book pages. Could you try to merge the two?
#3
Updated. Merged the parts of Damien's patch which weren't covered by my first one (deletion and the associated checks), and made the new book page type and default book page type tests use a dynamically generated content type. Interestingly enough I think I may have uncovered a bug in either core or the testing framework through doing this. After calling drupalWebTestCase::drupalCreateContentType() I have to do a menu_rebuild() to go to 'node/type/$type'. This rebuild is typically handled by node_type_form_submit which is never called in this context.
There are three options here...
depending on feedback here I'll either roll a patch for this or not. I think it probably shouldn't be the tests responsibility personally :).
Otherwise, I'd appreciate feedback on the rest of this patch as well.
#4
#5
After a chat with chx on irc I've gone with option #1, "The menu_rebuild should be moved to node_types_rebuild.".
This patch is now dependent on #306316: Regression: node_types_rebuild should rebuild menu
#6
The last submitted patch failed testing.
#7
Fairly certain this failed testing due to the listed dependencies. It would still be nice to have this reviewed.
#8
The last submitted patch failed testing.
#9
with #306316: Regression: node_types_rebuild should rebuild menu now committed, marking this back to CNR
#10
The last submitted patch failed testing.
#11
I rerolled this patch against the latest Drupal HEAD. I have not tested it locally, though.
#12
This is failing fairly spectacularly in local testing (all book tests results in 292 passes, 9 fails, and 17 exceptions). I hit the bot for a retest. Will try and check back to see how that goes and re-roll unless someone beats me to it.
#13
Ok, just figured out that there is an error which is keeping the testing bot from running the book.test at all:
Fatal error: Cannot use object of type stdClass as array in /Library/WebServer/Documents/botsite/modules/book/book.test on line 121
Will fix and re-roll patch and post in a bit unless someone else beats me to it.
UPDATE: Still working on this - the last patch post was quite a mess and not well commented. Taking forever actually. If someone gets impatient I'm glad to post my progress to date, otherwise will try to post a proper patch when I can.
#14
Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.