Download & Extend

TestingParty08: Sending one line e-mails

Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:p.brouwers
Status:needs work

Issue Summary

Need to test one line e-mail handling in mail.inc

Comments

#1

Assigned to:Anonymous» nielsvm

Assigned!

#2

Assigned to:nielsvm» Anonymous

Sorry, withdrew myself. Too busy for now. If I've got more time I will try to pick up more tests.

#3

Component:tests» base system
Assigned to:Anonymous» p.brouwers
Status:active» needs review

made a small test for it

AttachmentSizeStatusTest resultOperations
mail_test.patch2.12 KBIdleFailed: Failed to apply patch.View details | Re-test

#4

Status:needs review» needs work

<?php
+    $this->assertTrue(strpos($message['body'], '\n')===FALSE, t('Testing a one line mail'));
?>

Need spaces on either side of ===

#5

Sorry for my ignorance, but why should there be a specific test for single-line e-mails (what specifically should be tested)?

Pending patch has some code style errors, and with the advent of #296001: Capture e-mails sent during tests and add e-mail assertions / API it can probably be simplified a lot.

#6

Category:bug report» task
Priority:critical» normal

Moving this out of the critical bugs queue - see #607038: Meta issue: fix gaps in code coverage.

#7

Status:needs work» needs review

Changed the patch to use the new email-capture system and fixed the code style

AttachmentSizeStatusTest resultOperations
mail_test.patch2.18 KBIdleFailed on MySQL 5.0 ISAM, with: 14,740 pass(es), 0 fail(s), and 3 exception(es).View details | Re-test

#8

Status:needs review» needs work

The last submitted patch failed testing.

nobody click here