It would be nice to see some extra functions, like screensize detection ("800*600 is very small, please buy a new monitor"), javascript detection (if javascript !=on, the message will not be removed). In this way, this module could be evolve to a 'browser-message-system'.

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Closed (won't fix)

Browser detection is very bad practice. Feature detection is the way to go. The message will not be removed when Javascript is disabled anyway.

MatthijsG’s picture

MatthijsG commented

"Browser detection is very bad practice" Says the maintainer of the IE Destroyer project? Please explain ...

When i'm looking to my stats, only 5% doesn't have a good screen resolution

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Firstly, browser detection is bad because there is no full proof way to determine what browser a visitor is using. Secondly, in most cases you don't want to respond to a certain browser, but to a lack of a certain feature. That's why feature detection should be used in 99.99% of all cases people even think about using browser detection. Since IE Destroyer targets IE users, no matter what version they use this module doesn't belong to that 99,99%, but to the 0,01% of the cases in which actual browser detection is necessary.

If you're having problems with your users using a wide variety of resolutions, you might want to rethink your ideas about your target audience (Limit the supported resolutions to a width of 1000px-infinity for instance) or improve your CSS skills.

OnkelTem’s picture

OnkelTem commented

Feature detection? Right.
No need to kick IE7 users.
No any sane reason.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

I have no idea what you mean. Please be clear about what you want to say or stop flaming.

OnkelTem’s picture

OnkelTem commented

> I have no idea what you mean. Please be clear about what you want to say or stop flaming.

"Feature detection? Right." - agreement, is it?

"No need to kick IE7 users." - the lack of configurable browser filter is disadvantage. Currently ALL IE users are affected while in MOST cases we don't want IE<=6.

"No any sane reason." - the only reason to fight with a browser - lack of features. IE6 is the case. But I see no reason to fight with IE7 users.

... I have no idea what you haven't understood.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Your comment looked like a flame, because the response sounded sarcastic. My apologies.

The whole idea behind the module is to convert all IE users to another browser. This has IMO nothing to do with a lack of features, rather than a dislike of IE.

Anyway, I'm not really maintaining this module anymore since I don't use it (I maintained it for a while because it seemed like a nice module to get some browser detection experience)

OnkelTem’s picture

OnkelTem commented

> This has IMO nothing to do with a lack of features, rather than a dislike of IE.

Well, on a site which I make now I installed this module for notifying IE<=6 users - guys, you are using the browser which was released 8 years ago!

Hope this at least will make them think...

Minor modification was required actually in a module code for version checking to start working.