Synchronize Zen's tpl files with core's tpl files [#299397]

Zen's tpl files need to be compared to the corresponding core tpl files.

Core tpl files haven changed significantly since D5, so Zen's 6.x tpl files (which are mostly similar to their 5.x counterparts) are missing some of the new variables available in the d6 core tpl files.

Comment	File	Size	Author
#3	zen.patch	3.22 KB	prbass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

prbass CreditAttribution: prbass commented 3 September 2008 at 15:32

Assigned:	Unassigned	» prbass
Category:	bug	» task

Right, it seems that this request has been met with a deafening wall of silence. I have some free time this week and so I tentatively volunteer to do this

I haven't had to do any D6 theming yet, and although the differences don't seem to be that huge, this would be a great way to have a proper look at some of the new stuff under the hood.

However, one thing that immediately strikes me as new about the D6 files compared to the D5 ones is that there seem to be loads more of them! Do you need a Zen version of all of the core template files listed at: http://drupal.org/node/190815, or shall I just focus on the ones that are already in the theme?

Comment #2

JohnAlbin

he/they/他

English

Taipei, Taiwan

CreditAttribution: JohnAlbin commented 3 September 2008 at 15:41

Cool, Peter!

Actually, I'm the maintainer and I set that as a note to do it myself when I had a chance. But help is greatly appreciated!

Just do the tpl files that are already in Zen. We don't want any tpl files in Zen that are exact duplicates of the core ones; we don't want redundancy. :-)

Comment #3

prbass CreditAttribution: prbass commented 5 September 2008 at 18:51

Status:

Active

» Needs review

File	Size
zen.patch	3.22 KB

John,

This is a pretty minor contribution I'm afraid. Got as far as comment.tpl.php and remembered that D6 split $content to provide dynamic $signature per user.

I never really enable signatures - so I'm not really sure how it should be handled. Doesn't seem worth it for mostly non-authenticated users.

This also brings up a whole load of "separator" issues - it seems like they plumbed for a &endash; in Garland, but I think this looks a bit ugly. I would to prefer to theme the .signature div

I suppose another alternative would be to provide a theme setting - but this is perhaps overkill?

This patch also adds a comment-new class to mirror the improvement in Garland.

I'm afraid I've run out of time - not very helpful - but at least I tried!

Peter