[master]Display of Phone & Fax numbers [#299449]

Comment	File	Size	Author
#11	location.tpl_.php_.patch	1001 bytes	jenna.tollerson

Comment #1

ambereyes commented 26 September 2008 at 19:18

Version:

5.x-3.0-test2

» 5.x-3.0-test3

Okay. I found the problem. Although the api call does pull both the phone and fax values, they were not being processed in the preprocess function, template_preprocess_location, beginning at line 1886 of location.module.

I was not sure what function to use in a module invoke call to add them in programmatically, so I just added them to the list, i.e.

So this starting at line 1918

  foreach (array('street', 'additional', 'city', 'province', 'country', 'postal_code', 'province_name', 'country_name') as $key) {...}

became this

   foreach (array('street', 'additional', 'city', 'province', 'country', 'postal_code', 'province_name', 'country_name', 'phone', 'fax') as $key) {...}

I also added the following to the location.tpl.php file

<?php if ($phone) {?>
	<div class="phone">
		<strong>Phone:</strong>
		<?php  echo $phone; ?>
		</div>
		<?php if ($fax) { ?>
		<div class="fax"><strong>Fax:</strong>
			<?php echo $fax; } ?>
	</div>
	<?php }?>

I hope this helps someone else. Obviously, you would need to modify the tpl file to fit your requirements.

Log in or register to post comments

Comment #2

bdragon commented 9 October 2008 at 23:09

Title:

Display of Phone & Fax numbers

» [master]Display of Phone & Fax numbers

Blessing. Duplicates marked.
#188930: phone number and fax number not showing
#193573: How do I get phone numbers to display?

Log in or register to post comments

Comment #3

nvoyageur commented 5 November 2008 at 14:07

I think your </DIV> tags get printed even if there are no phone or fax info. This broke my site layout. I've used the following in location.tpl.php instead and it works when a phone and/or fax is not present.

<?php if ($phone): ?>
<div class="phone"><strong>Phone:</strong><?php print $phone; ?></div>
<?php endif; ?>

<?php if ($fax): ?>
<div class="fax"><strong>Fax:</strong><?php print $fax; ?></div>
<?php endif; ?>

Log in or register to post comments

Comment #4

ambereyes commented 5 November 2008 at 21:55

Yeah, you are right.

My design had the same problem, but I forgot to post the modified version. Sorry!

Your fix matches up with what my designer suggested.

Log in or register to post comments

Comment #5

zet commented 18 January 2009 at 01:15

bdragon, why you did not included this patch in the new version ?

Log in or register to post comments

Comment #6

zetxek commented 14 March 2009 at 11:43

If you want your "Phone" and "Fax" labels to be translatable, just add t() around the labels (it's the way it should be if you have a non-english drupal):

<?php if ($phone): ?>
<div class="phone"><strong><?php print t("Phone")?>:</strong><?php print $phone; ?></div>
<?php endif; ?>
<?php if ($fax): ?>
<div class="fax"><strong><?php print t("Fax");?>:</strong><?php print $fax; ?></div>
<?php endif; ?>

Log in or register to post comments

Comment #7

yesct commented 16 April 2009 at 11:17

Status:	Active	» Needs work
Issue tags:		+Location theming, +location extra location fields like phone etc

Tagging.

Could someone check these are not fixed in the latest dev release and then make a patch http://drupal.org/patch/create

Log in or register to post comments

Comment #8

jenna.tollerson

she/her

English

Atlanta, Georgia, USA

commented 15 May 2009 at 20:37

Version:

5.x-3.0-test3

» 5.x-3.x-dev

I can confirm that this is still not working in the latest dev release.

If I understood exactly what needed to be patched I would try to make one, but the suggestions here (and in the duplicate threads) do not seem to correlate with the latest release, so I feel a little lost.