Using Jul-01 6.x-2.x-dev. I tested my site's event RSS feed and noticed that items were ordered by creation date instead of start date. I'm no expert on RSS, so if this is the way an RSS feed is supposed to work, go ahead and kill as wontfix. I just think it looks nicer for a list of events to be ordered by the event start date.
This is very easily changed by editing event.module line 848 in event_calendar_rss():
//$result = event_get_events(event_implode_date($date), event_implode_date($end_date), $rewrite_parameter);
$result = event_get_events(event_implode_date($date), event_implode_date($end_date), 'ASC', $rewrite_parameter);You can do the same in event_calendar_ical() on line 908, but I have no access to iCal to know if this would be desirable or even work at all. The change can be tested by first pulling down data in iCal, then adding an event between two existing events, and finally pulling down data again. See if it breaks what the program reports or if the program reports the list correctly. The same procedure can be done in an RSS reader to test the RSS change unless someone knows enough to know that it will or won't work.
Note: $rewrite_parameter is supposed to be the fourth argument to event_get_events(), with the third being a string specifying sort order. These are the only two places I found where $rewrite_parameter is passed in as $order. The code doesn't break because the empty array is read as False, an accepted value. For quick reference, here is the function definition from line 1235:
function event_get_events($first, $last, $order = 'ASC', $rewrite_parameter = array()) {
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | event_rss_order.diff | 991 bytes | dturover |
Comments
Comment #1
dturover commentedComment #2
killes@www.drop.org commentedthanks!
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.