CommentFileSizeAuthor
#7 3001640-6.patch18.82 KBjibran
#5 3001640-5.patch17.65 KBjibran
#5 interdiff-00dd65.txt427 bytesjibran
#4 3001640-4.patch17.46 KBjibran
#4 interdiff-0a6102.txt3.92 KBjibran
#2 3001640-2.patch13.54 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 3001640-2.patch13.54 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3001640-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-0a6102.txt3.92 KB
new 3001640-4.patch17.46 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-00dd65.txt427 bytes
new 3001640-5.patch17.65 KB

  • jibran committed 756520b on 8.x-1.x 
    Issue #3001640 by jibran: Add drupalci.yml
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
StatusFileSize
new 3001640-6.patch18.82 KB

  • jibran committed dd8efcc on 8.x-2.x 
    Issue #3001640 by jibran: Add drupalci.yml
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This looks almost exactly like jsonapi's phpcs.xml and drupalci.yml! :D Especially since #3000299: Let phpcs violations fail the build on DrupalCI!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

This looks almost exactly like jsonapi's phpcs.xml and drupalci.yml!

What can I say your module inspired me, sir!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Hah, okay :D What a fun coincidence that I should find this issue then :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.