Download & Extend
Issues

Remap field as BLOB: {boxes}.body

Posted by hswong3i on August 26, 2008 at 4:58pm
Project:Drupal core
Version:8.x-dev
Component:block.module
Category:feature request
Priority:normal
Assigned:hswong3i
Status:needs work

Issue Summary

As case mentioned in #147947, this patch remap {boxes}.body as BLOB type.

The code logic should be correct, but it is now buggy for MySQL. It is because of INSERT DELAYED implementation in db_insert() which buggy when call db_last_insert_id() just after it, and MySQL don't support default value for TEXT/BLOB. I will mention the above bugs in other issues.

AttachmentSizeStatusTest resultOperations
boxes-body.patch3.22 KBIdleFailed: Failed to apply patch.View details | Re-test
Login or register to post comments

Comments

#1

Posted by hswong3i on August 27, 2008 at 6:51pm
Status:needs work» needs review

Remove the use of db_last_insert_id(), and also merge with http://drupal.org/node/300219 for correct schema definition.

MySQL:

  • update.php: pass (remember to access admin/build/themes and re-click active and default theme after update.php, it should be another bug across D6/7)
  • Insert new custom block: pass, both flash install or after upgrade.
  • Update existing custom block: pass, both flash install or after upgrade.

PostgreSQL:

  • update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
  • Insert new custom block: pass, for flash install
  • Update existing custom block: pass, for flash install
AttachmentSizeStatusTest resultOperations
boxes-body.patch4.09 KBIdleFailed: Failed to apply patch.View details | Re-test

#2

Posted by hswong3i on September 24, 2008 at 6:01pm

Revamp with drupal_write_record() for simpler handling.

When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for pid and uid when compare with using db_insert() directly.

Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

AttachmentSizeStatusTest resultOperations
boxes-body.patch5.09 KBIdleFailed: Failed to apply patch.View details | Re-test

#3

Posted by hswong3i on October 8, 2008 at 5:41pm

Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.

Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

AttachmentSizeStatusTest resultOperations
boxes-body-1223484987.patch3.97 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch boxes-body-1223484987.patch.View details | Re-test

#4

Posted by Anonymous (not verified) on November 12, 2008 at 10:10am
Status:needs review» needs work

The last submitted patch failed testing.

#5

Posted by marcvangend on February 28, 2010 at 3:51pm
Version:7.x-dev» 8.x-dev

Moving this to D8 now that #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB has been moved to D8 as well.

#6

Posted by roma.k on December 14, 2010 at 5:16am
Status:needs work» needs review

#7

Posted by catch on October 1, 2010 at 1:43pm
Priority:critical» normal

Not critical. May not even be valid any more.

#8

Posted by System Message on March 23, 2011 at 7:31pm
Status:needs review» needs work

The last submitted patch, boxes-body-1223484987.patch, failed testing.

nobody click here