Remap field as BLOB: {boxes}.body
hswong3i - August 26, 2008 - 16:58
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | block.module |
| Category: | feature request |
| Priority: | critical |
| Assigned: | hswong3i |
| Status: | needs work |
Description
As case mentioned in #147947, this patch remap {boxes}.body as BLOB type.
The code logic should be correct, but it is now buggy for MySQL. It is because of INSERT DELAYED implementation in db_insert() which buggy when call db_last_insert_id() just after it, and MySQL don't support default value for TEXT/BLOB. I will mention the above bugs in other issues.
| Attachment | Size |
|---|---|
| boxes-body.patch | 3.22 KB |
| Testbed results | ||
|---|---|---|
| boxes-body.patch | failed | Failed: Failed to apply patch. Detailed results |
#1
Remove the use of db_last_insert_id(), and also merge with http://drupal.org/node/300219 for correct schema definition.
MySQL:
PostgreSQL:
#2
Revamp with drupal_write_record() for simpler handling.
When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for
pidanduidwhen compare with using db_insert() directly.Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
#3
Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.
Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
#4
The last submitted patch failed testing.