Inter domain linking

Hi I would like to have an option where DA rewrites all outbound links to other affiliate nodes but not rewriting links to nodes that are published to all affiliates.

This already exists. Look under the Advanced Settings for "Default source domain" -- see attached.

Checking the url_alias for prefixing would be possible, but take a little code trickery. I would like to see a patch for that.

You must enable Domain Source, even if you do not use it.

[edit: I said "Domain Strict" originally, which is incorrect.

What am I supposed to be seeing?

This feature is in 5.x.1.5 and higher. It does not require Domain Source.

Now I see. The patch is appropriate, but you should compare the custom_url_rewrite_outbound() function in both versions as well, since we act based on that setting in that function.

You can (in D5) alter path aliasing by using custom_url_rewrite(). DA includes a patch that backports custom_url_rewrite_outbound() and custom_url_rewrite_inbound() from D6. With some modification to custom_url_rewrite_outbound(), you could do domain-specific path lookups.

You would have to determine the target domain for the link, then switch database tables, and then write the link. It is possible, but I do not have time at the moment.

custom_url_rewrite_outbound() on D5 is called before drupal_get_path_alias() 

The included patch does that? If so, we should rewrite the patch.

Looks good, just from reading through the code. This will need to go into the 5.x.2 / 6.x.2 release, since it changes the patch that needs to be applied.

Are your tests working as expected?

The only other thing I can think is how to make this optional, so that we only use this routine in certain cases. Maybe we provide a separate include with Domain Prefix so that, if you want this feature, you place a different include file in settings.php.

Status change!

That makes sense. Take a look at the domain_uri() function, it may need to be extneded with your path logic.

I don't know. I am in Budapest after DrupalCON Szeged, and will not get a chance to really think about this until Monday.

Just took a look. The one part that I don't like is the direct call to domain_prefix_get_path_alias() and the function_exists() that goes with it.

It would be more Drupal if we used a hook here instead.

So I suppose we would need hook_domainpath(), which would let other modules modify the path.

<?php
hook_domainpath($domain_id, $path, $path_language = '') {
 // code here
}
?>

Then we can just invoke the hook without having to use the function_exists() bit in our code. In this case, we do not need a separate settings.php file for Domain Prefix.

Using a hook is how we do things. Look at hook_domainload() or hook_nodeapi().

Will there be cases where modules compete? Possibly, but that can be fixed at the module level. Our task is to build a modular framework that supports extension. Running module-specific functions calls (exceptions, really) goes against that goal.

OK, the patch from #7 has been committed to the d5 branch -- it is easy to lose track of multiple patches in an issue.

This got confused with another patch. #7 has been committed. #24 still needs review.

D6 HEAD is working. Domain Views is incomplete, but the rest should be fine. See http://drupal.org/node/320388

This should actually apply to D6 pretty cleanly.

This has been committed to HEAD (D6). Note that I took the opportunity to optimize the way this code works.

Two special considerations:

-- Any implementation of this hook will now run on _all_ path lookups, not just when DA rewrites the path. This is by design, since there are paths other than node paths that might need to be rewritten.

-- Because of this, the hook could be _very_ resource intensive. So I broke it out into a special file that is only loaded IFF we know that a prefixed {url_alias} table is present. This saves a ton of potential calls to the function that might not be needed.

For details, see domain_prefix_init() and domain_prefix.path.inc.

Updated patch attached for D5 reference -- though the patch is for D6.

I took that last bit out last night, so check the newest version of HEAD.

The code in custom_url_rewrite.inc is correct. Because of how the Domain Switcher block works, we have to run some checks against the default 'url_alias' table.

And no, custom_url_rewrite.inc is designed to _only_ rewrite node paths -- see the check for if ($nid) near the top. So it would have had no effect if you wanted to change path aliases for a path like 'user,' so we have to run the multi-domain path lookup on _every_ path. The result, if you have multiple domains, is that you might end up running dozens or hundreds of path lookups per page.

The code seems to be as optimized as it can be, though.

Please test before claiming that something doesn't work.

Yes, you were correct. I had tested it in the Domain Switcher, but not in custom_url_rewrite().

Patches committed to HEAD.

The problem that remains -- which I am not sure how to solve -- is what to do if you have two separate aliases for a path that is not a node. The Domain Switcher handles this through the use of domain_get_uri(). But normal links do not, and I do not see any way to handle that without some very nasty regex code that I don't think we need.

In most cases, this will not be an issue, though I could see problems with menu links that span multiple domains -- unless they are node paths, they will not be aliased correctly. So perhaps just a documentation note about the limitations of this approach.

I mean 'two separate aliases (on two different prefixed domains) for the same path that is not a node path.'

New patch committed. Nice fixes.

I think that needs to be accounted for. Committed to HEAD.

function domain_prefix_domainpath($domain_id, &$path, $path_language = NULL) {
  global $language, $_domain;
  // $map[$domain_id] keys are Drupal paths and the values are the corresponding aliases
  static $map = array(), $count = array(), $status = array(), $tablename = array();

  // If the alias is for the current domain, do nothing.
  if ($domain_id == $_domain['domain_id']) {
    return;
  }
// ... rest of function ...

So you mean:

  // If the alias is for the current domain, do nothing.
  if ($domain_id == $_domain['domain_id']) {
    $path = drupal_get_path_alias($path);
    return;
  }

Ah. I didn't see the extra parameter in the function. This will have to wait until I get home.

If we do this check inside domain_path() itself, do we need to worry about the $original_path var?

The small D6 patch has been committed. Marking as to be ported.

I just committed a change to HEAD, since we were accidentally dropping language paths.

So this needs a retest.

This will need to be tested post-release, it appears.

Here's the patch from #51 revised for 5.x-dev.

I am confused about the note referring to #40.

Can you simply update the patch file with the changes to the custom_url patch?

Can you re-roll?

Can somebody confirm if this patch is only available for D5 and not yet ported to D6 ?

Thanks,
Tim

I have a few different domains which I use to access my company website, e.g. example.com, anotherexample.com and yetanotherexample.com. I also have sub domains for each domain, e.g. support.example.com, support.anotherexample.com and support.yetanotherexample.com. On some content which is shown in the main domain (e.g. example.com, anotherexample.com and yetanotherexample.com) I might refer to a page by URL (e.g. http://support.anotherexample.com/node/123). I am therefore looking for a way to make this URL get modified (re-written) so if a user logs onto example.com site and clicks on this link, it is changed to http://support.example.com/node/123. If I don't do this, the user will be taken to another domain, which I don't want, and also it means they have to logon again because of cookie_domain. So, is this patch/feature discussed in this issue, what I need, or have I missunderstood the use case ?

The thread indicates that the main patch was against D6 and was committed to 6.x-2.0-rc6. The port in question is a backport to D5.

Croryx,

Ok, thanks for confirming. Since I am using 2.1, it seems the patch will be included already. In that case, I am not sure why it is not working for me. Maybe I have missunderstood what it does ??? Does my example in #60 help ?

Thanks,
Tim

Tim - you should probably start a new issue for this as this is a separate (though certainly related) topic. The maintainers will be more likely to see it that way and they won't have to sift through the 60 messages in the current thread. I don't do anything like this, but if you haven't looked at the sub-module Domain Source yet, that's where I'd start.

Thankyou for your advice. I will create new issue.

@TimAlsop. Confirming that this thread is about something totally different.

Somewhat related... these linking issues are moot if $db_prefix is broken when using SSO...

#947298: SSO, Pathauto, and Domain_prefix are not compatible

Josh

D5 is closed.