Closed (fixed)
Project:
Rules
Version:
6.x-1.x-dev
Component:
Rules Engine
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Aug 2008 at 18:05 UTC
Updated:
2 Jan 2014 at 23:45 UTC
Jump to comment: Most recent
Comments
Comment #1
fagoNo, there is no way - as this rule set is a default rule set. However I think I'll remove this default rule set from the module.
Comment #2
avpadernoI would leave the example rule set, but I would load it in the database when the module is being installed; in that way, it would appear like one created by the user, and the user would be able to delete it whenever he wants.
At the moment the example rule set, and rule are loaded at runtime from a file; that means they will appear all times the admin interface is presented.
Comment #3
fagothat sounds to make sense - thanks for the suggestion. I think I'll follow that.
Comment #4
amitaibuI think it's better to keep it un-deletable. default rules are made for newbies, that might delete it by mistake. You can't delete default views as well, only disable them.
Comment #5
avpadernoThe case of the views is different, as the default views are the ones provided by some modules (including the core ones).
The rule sets are just provided as example, and they don't do anything useful (except that they can modified from the user).
Comment #6
fagohm, no in general default rules are intended to something - not as example. Only the provided one is intended to be an example, so yes it should be deletable. I think best is we change it to not be a default rule set, but just configure it as a usual rule set when the module is activated.
Comment #7
mitchell commentedI don't fully understand this, but here are some of the questions that seem pertinent:
Is it better to have the default rules in the database or as a file?
Should the default rules & rule sets be deletable or only able to be disabled?
Comment #8
avpadernoI would put them in the database, like any other rules; I would like better to be deletable, so I can delete them when I don't need them anymore.
Actually, they are good like examples, but they don't do something really useful; they can be used to build a more complex rule, but that is all they can be used for.
Comment #9
bekasu commentedWhy not do both?
1. Load the example to the database.
2. Allow the user to change or delete the example rule.
3. Provide another static file with installation which contains the example rule info
4. Provide a button (link) that will let the user put the rule back in if it has been deleted
Seems like that would let each side of this discussion accommodate their concerns.
Comment #10
fago>Is it better to have the default rules in the database or as a file?
Usually you have it in the file. But this is about a uncommon use case: Provide an example rule.
>Should the default rules & rule sets be deletable or only able to be disabled?
only able to be disabled
For this issue, I still think it's best to go with "custom rule" just inserted in the db.
Comment #11
fagoWhen doing so we have to to care for #300923: Export page should not present an empty list.
Comment #12
avpadernoThe issue about the export page is set as fixed. Do you mean it's not really fixed?
Comment #13
fagoIt's fixed as long as the list can't be empty - when this issue changes this and it can be empty, it's not.. ;)
Comment #14
fagokT
Comment #15
fago>For this issue, I still think it's best to go with "custom rule" just inserted in the db.
I've done so. When installing the rules admin module, the rules are inserted. For existing installations it's done by an update, which should also handle modified "old default rules" correctly. Please test.