Posted by hswong3i on August 27, 2008 at 9:04pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | comment.module |
| Category: | feature request |
| Priority: | critical |
| Assigned: | hswong3i |
| Status: | closed (duplicate) |
Issue Summary
As case mentioned in http://drupal.org/node/147947, this patch remap {comments}.comment as BLOB type. Also merge with http://drupal.org/node/300219 for correct schema definition.
MySQL:
- update.php: pass.
- INSERT/UPDATE: pass.
PostgreSQL:
- update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
- INSERT/UPDATE: FAILED. Seems db_insert() of PostgreSQL don't handle correctly.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| comments-comment.patch | 4.73 KB | Idle | Failed: Failed to apply patch. | View details | Re-test |
Comments
#1
Revamp with drupal_write_record() for simpler handling.
When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for
pidanduidwhen compare with using db_insert() directly.Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
#2
Revamp with drupal_write_record() for simpler handling.
When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for
pidanduidwhen compare with using db_insert() directly.Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
#3
Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.
Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
#4
The last submitted patch failed testing.
#5
Patch reroll after DBTNG syntax revamp #314532: DBTNG comment.module. Only change schema as BLOB type. Pass all comment's simpletest.
#6
The last submitted patch failed testing.
#7
See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
#8
duplicate with #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB