The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.As case mentioned in http://drupal.org/node/147947, this patch remap {comments}.comment as BLOB type. Also merge with http://drupal.org/node/300219 for correct schema definition.
MySQL:
- update.php: pass.
- INSERT/UPDATE: pass.
PostgreSQL:
- update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
- INSERT/UPDATE: FAILED. Seems db_insert() of PostgreSQL don't handle correctly.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | dbtng-comments-comment-1226549584.patch | 1.14 KB | hswong3i |
| #3 | comments-comment-1223485861.patch | 3.21 KB | hswong3i |
| #2 | comments-comment.patch | 3.93 KB | hswong3i |
| comments-comment.patch | 4.73 KB | hswong3i |
Comments
Comment #1
hswong3i commentedRevamp with drupal_write_record() for simpler handling.
When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for
pidanduidwhen compare with using db_insert() directly.Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
Comment #2
hswong3i commentedRevamp with drupal_write_record() for simpler handling.
When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for
pidanduidwhen compare with using db_insert() directly.Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
Comment #3
hswong3i commentedUpdate based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.
Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.
Comment #4
Anonymous (not verified) commentedThe last submitted patch failed testing.
Comment #5
hswong3i commentedPatch reroll after DBTNG syntax revamp #314532: DBTNG comment.module. Only change schema as BLOB type. Pass all comment's simpletest.
Comment #7
lilou commentedSee: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
Comment #8
hswong3i commentedduplicate with #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB