As case mentioned in http://drupal.org/node/147947, this patch remap {comments}.comment as BLOB type. Also merge with http://drupal.org/node/300219 for correct schema definition.

MySQL:

  • update.php: pass.
  • INSERT/UPDATE: pass.

PostgreSQL:

  • update.php: FAILED. Seems PostgreSQL schema don't handle change field correctly.
  • INSERT/UPDATE: FAILED. Seems db_insert() of PostgreSQL don't handle correctly.
CommentFileSizeAuthor
#5 dbtng-comments-comment-1226549584.patch1.14 KBhswong3i
#3 comments-comment-1223485861.patch3.21 KBhswong3i
#2 comments-comment.patch3.93 KBhswong3i
comments-comment.patch4.73 KBhswong3i

Comments

hswong3i’s picture

hswong3i commented

Revamp with drupal_write_record() for simpler handling.

When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for pid and uid when compare with using db_insert() directly.

Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

hswong3i’s picture

hswong3i commented
StatusFileSize
new comments-comment.patch3.93 KB

Revamp with drupal_write_record() for simpler handling.

When combine with simplify drupal_write_record() with db_insert() and db_update(), it can prevent the incorrect input type for pid and uid when compare with using db_insert() directly.

Tested with MySQL and PostgreSQL. Stand alone simpletetest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

hswong3i’s picture

hswong3i commented
StatusFileSize
new comments-comment-1223485861.patch3.21 KB

Update based on http://drupal.org/node/316095 founding. Revamp BLOB field with nullable.

Tested with MySQL and PostgreSQL. Stand alone simpletest, pass; simpletest when combine with http://drupal.org/node/299088, also pass.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

hswong3i’s picture

hswong3i commented
Title: Remap field as BLOB: {comments}.comment » [DBTNG + BLOB] remap {comments}.comment
Status: Needs work » Needs review
StatusFileSize
new dbtng-comments-comment-1226549584.patch1.14 KB

Patch reroll after DBTNG syntax revamp #314532: DBTNG comment.module. Only change schema as BLOB type. Pass all comment's simpletest.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

hswong3i’s picture

hswong3i commented
Status: Needs review » Closed (duplicate)

duplicate with #147947: [DBTNG + XDB] Replace some TEXT:BIG with BLOB