Site hangs when enabling domain.module [#300825]

Comment	File	Size	Author
#38	enable.patch	2.19 KB	agentrickard

Comment #1

asd123asd5 commented 27 August 2008 at 23:05

Actually the new version fixed the fact that I get white pages after I stop it when it hangs, but it still hangs.

Log in or register to post comments

Comment #2

asd123asd5 commented 27 August 2008 at 23:43

Ok, I have tested it with a live virtuozzo running linux, still no go.

Log in or register to post comments

Comment #3

asd123asd5 commented 28 August 2008 at 01:58

Works on fresh install, must be a clash with a module or something else. Will continue looking into it :(

Log in or register to post comments

Comment #4

agentrickard

he/him

English

Georgia (US)

commented 28 August 2008 at 05:32

Status:

Active

» Postponed (maintainer needs more info)

Marking as needs info. Let's keep this open for a week or so, just in case.

Log in or register to post comments

To follow up on my previous post, I can confirm #3: I don't either get the problem on a fresh install. However, I do get it on an install with only required core modules are enabled, after disabling all other modules.

Log in or register to post comments

Comment #7

agentrickard

he/him

English

Georgia (US)

commented 28 August 2008 at 19:52

@fp-

This is a simple memory limit issue. You should give Drupal at least 32MB.

Log in or register to post comments

Comment #8

fp commented 28 August 2008 at 22:36

I know. This is using 100MB... which points to some memory leak.

Log in or register to post comments

Comment #9

agentrickard

he/him

English

Georgia (US)

commented 29 August 2008 at 07:50

Are you enabling DA on a site that already has a lot of nodes (100,000 >)?

Log in or register to post comments

Comment #10

fp commented 29 August 2008 at 16:09

No, only a handful of nodes. I will try to reproduce the problem starting from scratch and update with my findings.

Log in or register to post comments

Comment #11

bribiz commented 21 September 2008 at 15:12

I too am having the same problem as described above. I have installed version 1.8 and still same problem. I previously had domain access working under version 1.4 until I tried to install 1.7 and 1.8.

Did anyone find a resolution to this issue? There must be some common issue.

Log in or register to post comments

Comment #12

agentrickard

he/him

English

Georgia (US)

commented 22 September 2008 at 13:24

You site hangs during the 'update node access' process? This could actually be a JS issue.

Log in or register to post comments

Comment #13

bribiz commented 22 September 2008 at 13:56

Tried it on Google Chrome instead of Firefox. Chrome reported:

=================
This webpage is not available.

The webpage at http://www.(mydomain).com/admin/build/modules/list/confirm might be temporarily down or it may have moved permanently to a new web address.

More information on this error
Below is the original error message

Error 320 (net::ERR_INVALID_RESPONSE): Unknown error.
==================
Does error 320 relate to a JS issue? I'm not familiar with error 320.

Log in or register to post comments

Comment #14

bribiz commented 22 September 2008 at 14:10

Okay error 320 could be a Google issue. Tried it in IE -- same problem. I then increased my max_execution_time in php.ini to 300 seconds and tried it again in Firefox. After less than 300 seconds it still died again.

Log in or register to post comments

Comment #15

agentrickard

he/him

English

Georgia (US)

commented 22 September 2008 at 15:01

You are running the update from your registered 'primary domain,' right?

Log in or register to post comments

Comment #16

agentrickard

he/him

English

Georgia (US)

commented 22 September 2008 at 15:09

I read through this bug report for Chrome and it makes me wonder if this is a general problem with either a) some web server / browser combinations, or b) something that needs to be fixed in Drupal core.

Do any of the other Drupal batch processes fail?

Log in or register to post comments

Comment #17

bribiz commented 22 September 2008 at 15:43

I don't have any other batch processes to run but I'm willing to install another module that does to try it.

I decided to test the memory leak issue. I have max_execution_time set to 300 and I upped the memory to 256M in php.ini. I then try to install domain access and I used top to watch the memory and cpu.

After about 5 minutes it died. It consumed all available memory on my 2GIG dedicated server. I saw one httpd process continue to climb to over 15% of memory. The httpd process and a mysqld process consumed about 50% of cpu each on my dual quad core system throughout the process.

It's like it's stuck in a continuous loop, a runaway query or something. It could also be some sort of config conflict issue but would the browser cause a process to continue on like this?

Log in or register to post comments

Comment #18

agentrickard

he/him

English

Georgia (US)

commented 22 September 2008 at 16:00

I would refer you to #15. You did configure DA before running the node update, right?

Log in or register to post comments

Comment #19

agentrickard

he/him

English

Georgia (US)

commented 11 October 2008 at 12:58

Status:

Postponed (maintainer needs more info)

» Closed (fixed)

Log in or register to post comments

Comment #20

awolfey commented 15 October 2008 at 01:40

I seem to have had a similar problem using DA 1.9 on a couple of attempts to install it.

I apply the patches I need, edit the files that require editing, enable the main DA module and none of its helper modules, and Drupal hangs when I submit the module configuration page. After a couple of minutes I cancel the page load and refresh and it appears that DA is installed correctly. It works. Meanwhile, there is an apache process ongoing related to the enable of the module. When I noticed there was a problem watchdog had filled up, this time with 22 million records. I only caught it after the server gave notice that the disk was almost full.

Here's a sample error:

Duplicate entry '1-0-domain_editor' for key 1
query: INSERT INTO domain_access (nid, gid, realm) VALUES (1, 0, 'domain_editor') in /home/user/public_html/vcn/includes/database.mysql.inc on line 172.

So I disabled and uninstalled DA. Killed the bad apache process. Cleaned up watchdog. Re-enabled DA and again the module configuration hangs and the watchdog entries start piling up.

Then, trying again I just disable, I don't uninstall DA, kill the apache process filling up watchdog and empty watchdog. But this time DA renables without any problems and is working.

I have a large number of contributed modules installed. I'm willing to run some tests or provide more details if anyone has suggestions or questions.

Aaron

Log in or register to post comments

Comment #21

awolfey commented 15 October 2008 at 01:41

Status:

Closed (fixed)

» Active

Sorry, reopening.

Log in or register to post comments

Comment #22

agentrickard

he/him

English

Georgia (US)

commented 15 October 2008 at 13:57

Version:

5.x-1.7

» 5.x-1.9

This appears to me to be an error related to the enable/disable of the module. Here's the function in question:

function domain_enable() {
  domain_enabling(TRUE);
  // Thanks to the new way that batch processing of node grants is handled, we have to
  // manually define our records if none are present.
  $count = db_result(db_query("SELECT COUNT(*) FROM {domain_access}"));
  if ($count == 0) {
    $rule = variable_get('domain_behavior', DOMAIN_INSTALL_RULE);
    $edit = variable_get('domain_editors', DOMAIN_EDITOR_RULE);
    $site = DOMAIN_SITE_GRANT;
    $nids = db_query("SELECT nid FROM {node}");
    while ($nid = db_result($nids)) {
      if (!empty($site)) {
        db_query("INSERT INTO {domain_access} (nid, gid, realm) VALUES (%d, %d, '%s')", $nid, 0, 'domain_site');
      }
      if (!empty($rule)) {
        // By design, all nodes are assigned to the master domain.
        db_query("INSERT INTO {domain_access} (nid, gid, realm) VALUES (%d, %d, '%s')", $nid, 0, 'domain_id');
        // Editor rules only apply is nodes are assigned to a domain.
        if (!empty($edit)) {
          variable_set('domain_editors', TRUE);
          db_query("INSERT INTO {domain_access} (nid, gid, realm) VALUES (%d, %d, '%s')", $nid, 0, 'domain_editor');
        }
      }
    }
  }
  // Rebuild the node access table with our rules.
  node_access_rebuild();
  // Set the default 'domain_all' grant for special pages.
  domain_set_default_grant();
}

You appear to be getting multiple inserts for node id 1, domain id 0, realm 'domain_editor'.

This should not be happening for two reasons:

-- The insert should not run if the {domain_access} table is already populated.
-- The insert should only run once per node id.

I cannot replicate this error. My suspicions are as follows:

-- The module was disabled improperly, either directly through the database, or through another method.
-- You are running a version of MySQL or pgSQL that does not behave as expected.

Perhaps these queries are returning bad results:

  $count = db_result(db_query("SELECT COUNT(*) FROM {domain_access}"));

    $nids = db_query("SELECT nid FROM {node}");
    while ($nid = db_result($nids)) {

Perhaps that second query needs to be different:

    $result = db_query("SELECT nid FROM {node}");
    while ($nids = db_fetch_object($result)) {
      $nid = $nids->nid;
   ....

Log in or register to post comments

Comment #23

agentrickard

he/him

English

Georgia (US)

commented 15 October 2008 at 14:04

For the record, this is tested on:

MySQL 5.0.41
PHP 5.2.5

Log in or register to post comments

Comment #24

awolfey commented 15 October 2008 at 18:25

I am using PHP 5.2.6 and MYSQL 5.0.51a.

The module was disabled and uninstalled through Drupal, not the database.

I have these settings in domain.module:

define('DOMAIN_INSTALL_RULE', TRUE);
define('DOMAIN_EDITOR_RULE', TRUE);
define('DOMAIN_SITE_GRANT', TRUE);

I will test again and let you know.

Log in or register to post comments

Comment #25

awolfey commented 28 October 2008 at 17:21

I have not tried a reinstall, but looking again, it appears that I had not updated settings.php for domain_conf.inc before I enabled Domain and domain_conf (along with themes and content). Perhaps that was part of the problem.

Log in or register to post comments

Comment #26

agentrickard

he/him

English

Georgia (US)

commented 28 October 2008 at 18:11

That should not have an effect during the install process.

Log in or register to post comments

Comment #27

bribiz commented 4 November 2008 at 06:11

Okay...I finally worked on this again and I had the same problem on a completely different site with an almost fresh install recently upgraded on a completely different system. I checked my watchdog table and it grew from 264 records to over 64,000.

I did change the second query as referenced above in post #22 and it worked. I no longer had the white screen of death. (I still need to test out the module to confirm it really works!)

But it returned to the module list with a new error. I could not find where this query comes from or if this is important. I search the code and used grep with no luck.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND realm = 'domain_id')) AND grant_view >= 1' at line 1 query: SELECT COUNT(*) FROM www_node_access WHERE nid = 0 AND ((gid = 0 AND realm = 'all') OR (gid = AND realm = 'domain_id')) AND grant_view >= 1 in /chroot/home/mydir/mydomain/html/includes/database.mysql.inc on line 174.

BTW -- PHP = 5.1.6 and mysql = 5.0.45

Hope this helps!

Thanks,

Brian

Log in or register to post comments

Comment #28

agentrickard

he/him

English

Georgia (US)

commented 4 November 2008 at 14:07

So there are two issues here.

One is that the query in #22 may fail in PHP 5.1 -- that makes little sense to me.

Two is that the module list page ran a node access query. Which also makes no sense, unless you have blocks that display nodes appearing on that page.

And what are the watchdog records?

Log in or register to post comments

Comment #29

bribiz commented 4 November 2008 at 20:47

I believe the watchdog table is to log errors and monitor site. It is being replaced in d6. I found more info here: http://drupal.org/node/300

I believe the other person also reported the problem in PHP 5.2.6 so it may be more than just 5.1. I think some of the way PHP access databases and objects was change starting in 5.x which could be why your 2 line change worked.

As far as the other error goes, I have not encountered it since.

Log in or register to post comments

Comment #30

agentrickard

he/him

English

Georgia (US)

commented 4 November 2008 at 21:22

I know what watchdog is.

What is being _written_ to watchdog?

Log in or register to post comments

Comment #31

agentrickard

he/him

English

Georgia (US)

commented 4 November 2008 at 21:24

I still suspect something else, since I run PHP 5.2.5 and MySQL 5.0.41.

This is not a widespread problem, otherwise the issue queue would be full of people screaming.

Log in or register to post comments

Comment #32

bribiz commented 5 November 2008 at 05:30

I could run it again and take a look at the watchdog records but I suspect we both have better things to do since it isn't widespread.

Today I learned that you wrote both domain_access and mysite which are very significant modules. Just wanted to say thanks for your awesome contribution and I hope I can help these projects in the future somehow.

Log in or register to post comments

Comment #33

agentrickard

he/him

English

Georgia (US)

commented 5 November 2008 at 14:18

Well, I'll patch the queries as defined in #22, but still don't see the root cause.

Log in or register to post comments

Comment #34

4kant commented 7 November 2008 at 12:06

Title:

Site hangs when enabling domain.module

» Site hangs when editing a node

Hi,

I´m not sure whether this bases on the same cause.
I was looking for a thread concerning "memory problems" with DA.

In my case I get an endless waiting hour-glass when I click on "Save" editing a single node. No matter what I edited.
I had no problems during install of DA (on a website with drupal 5.12 with some nodes)

I noticed that the hour-glass only comes at the root Domain.
When I´m inside another domain everything (even the same node) works fine.

I still have to test - but maybe that´s already helpful for you (I´m not screaming...)

4k

Log in or register to post comments

Comment #35

agentrickard

he/him

English

Georgia (US)

commented 7 November 2008 at 14:04

Title:

Site hangs when editing a node

» Site hangs when enabling domain.module

@4kant

That is a separate issue.

Log in or register to post comments

Comment #36

rohnjeynolds commented 20 November 2008 at 18:03

Priority:

Normal

» Critical

As far as I can tell, the issue is caused by what's described in #22.

while ($nid = db_result($nids)) {

The db_result() function returns the first value found in the database; it doesn't iterate over the result set. So $nid will always be the first the ID for the first node encountered in the nodes table, and the while() loop will never end -- hence the hang and the thousands of 'duplicate key' entries in watchdog.
Change to db_fetch_array() or db_fetch_object() and update the references to $nid inside the loop accordingly, and the module will install.
Great module, but this is one nasty bug in the 5.x version.

Log in or register to post comments

Comment #37

agentrickard

he/him

English

Georgia (US)

commented 20 November 2008 at 18:59

Status:

Active

» Reviewed & tested by the community

Thanks for that report. It explains what I had suspected.

Log in or register to post comments

Comment #38

agentrickard

he/him

English

Georgia (US)

commented 20 November 2008 at 23:39

Status:

Reviewed & tested by the community

» Fixed

Status	File	Size
new	enable.patch	2.19 KB

For the record, I was never able to replicate this error, which may be a PHP version issue.

Committed anyway, since the fix works in all cases. Patch attached for reference.

Log in or register to post comments

Comment #39

4 December 2008 at 23:41

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Log in or register to post comments

Comment #40

mburak commented 13 January 2009 at 10:09

Just to make clear that there's no a PHP version problem here. It's just the Drupal 5 version of the db_result function.

<?php
function db_result($result, $row = 0) {
  if ($result && pg_num_rows($result) > $row) {
    $res = pg_fetch_row($result, $row);

    return $res[0];
  }
  return FALSE;
}
?>

As default, row is 0, so if you don't pass this param it will always try to fech the first row in the result. This doesn't happen in Drupal 6 because the function doesn't have this default row value.
Hope this helps to understand the issue.

Log in or register to post comments

Comment #41

mr.j commented 13 May 2009 at 04:06

You should consider releasing a 5.x-1.10 with this fix.
I just ran into the same problem installing the module in a shared hosting environment and had the host on my back because of a 'rogue' mysql process.

Log in or register to post comments

Site hangs when enabling domain.module

Comments