Theme calls cannot be overridden
jonathan_hunt - August 27, 2008 - 23:57
| Project: | Avatar Blocks |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | roopletheme |
| Status: | needs review |
Jump to:
Description
The block generation contains direct calls to theme_ functions. This prevents them being overridden by theme developers.
Index: modules/avatar_blocks/avatar_blocks.module
===================================================================
--- modules/avatar_blocks/avatar_blocks.module (revision 9516)
+++ modules/avatar_blocks/avatar_blocks.module (working copy)
@@ -319,7 +319,7 @@
while ($next_member = db_fetch_object($display_users)) {
$online_members[] = $next_member;
}
- $output = theme_avatar_blocks_block($online_members, $imagecache_preset);
+ $output = theme('avatar_blocks_block', $online_members, $imagecache_preset);
}
if (variable_get('avatar_blocks_ol_include_text', 0)) {
// Format the output with proper grammar.
@@ -356,7 +356,7 @@
while ($next_member = db_fetch_object($new_member_list)) {
$new_members[] = $next_member;
}
- $output = theme_avatar_blocks_block($new_members, $imagecache_preset);
+ $output = theme('avatar_blocks_block', $new_members, $imagecache_preset);
return $output;
}
@@ -388,7 +388,7 @@
while ($next_buddy = db_fetch_object($my_buddylist_list)) {
$buddies[] = $next_buddy;
}
- $output = theme_avatar_blocks_block($buddies, $imagecache_preset);
+ $output = theme('avatar_blocks_block', $buddies, $imagecache_preset);
}
}
return $output;
#1
Hey, thanks for pointing this out to me. Is the working copy referenced in your diff listing functioning as you expect?
#2
This is fixed in HEAD, and will be in the next release.