Download & Extend
Admin role » Issues

Use asort instead of ksort

Posted by marcingy on August 28, 2008 at 1:17am
Project:Admin role
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (works as designed)

Issue Summary

If a role is deleted and then an admin role is selected ksort causes the incorrect array value to be set in adminrole_adminrole. Instead asort should be used as this maintains the assocaited key order. I'd role a patch but.. as this is basically a one letter change on line 67 it doesn't seem worth it ;-)

Login or register to post comments

Comments

#1

Posted by marcingy on August 28, 2008 at 1:17am
Status:active» needs review

#2

Posted by marcingy on August 28, 2008 at 1:26am

On further investigation more changes are required so here is a patch

AttachmentSizeStatusTest resultOperations
admin role.patch857 bytesIgnored: Check issue status.NoneNone

#3

Posted by marcingy on August 28, 2008 at 1:28am
Title:ksort cause incorrect results» ksort cause incorrect results when role has been deleted

#4

Posted by Bevan on January 7, 2009 at 8:49pm
Status:needs review» postponed (maintainer needs more info)

I can't reproduce this bug. Please retest with drupal 6 dev and provide more detailed instructions to reproduce

#5

Posted by Bevan on January 7, 2009 at 9:14pm
Title:ksort cause incorrect results when role has been deleted» Use asort instead of ksort

#6

Posted by Dave Reid on November 25, 2009 at 3:36am
Status:postponed (maintainer needs more info)» closed (works as designed)

ksort maintains key => value associations so I don't see a bug here.