The highlighted block regions on the block configuration page appears below some objects on custom themes. This two rows fixes that. Hopefully a z-index of 99 is enough for most themes...

CommentFileSizeAuthor
#5 block.patch_0.txt467 bytesgopherspidey
drupal_css_svn.diff397 bytesanders.fajerson

Comments

anders.fajerson’s picture

anders.fajerson commented
Version: 4.6.0 » x.y.z
Uwe Hermann’s picture

Uwe Hermann commented

Just curious: You seem to diff against an svn repository. Which? Why? Do these patches apply cleanly and easily to current Drupal CVS HEAD?

anders.fajerson’s picture

anders.fajerson commented

I have a local subversion repositary and I'm too lazy to learn that cvs/diff stuff... sorry to you all.

It could also been seen as a sort of political statement in favour for subversion... :)

drumm’s picture

drumm
he/him
Location NY, US
commented

Any patch in unified diff format is fine, even from SVN. (But please keep your political statements out of the patch queue, we have real work to do.) And this even still applies.

Looks okay, but I'd like some more review on different themes. Looks okay with Bluemarine, but thats not even testing all the themes in core.

gopherspidey’s picture

gopherspidey commented
StatusFileSize
new block.patch_0.txt467 bytes

This has been rerolled to HEAD.

I had no bad affect on the core themes that I could tell.

beginner’s picture

beginner commented
Status: Needs review » Needs work

there is no drupal.css anymore.

gopherspidey’s picture

gopherspidey commented

beginner,

Try the patch under comment #5

I tested with HEAD as of tonight the patch under #5 still works with no error.

gopherspidey’s picture

gopherspidey commented
Status: Needs work » Reviewed & tested by the community
beginner’s picture

beginner commented

Oops. Sorry. I didn't notice that patch.
Thanks for pointing out my mistake.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Needs review

I think this is okay. I'd like to see a review from a css-type, such as Steven or m3avrck.

What type of css layout do themes which need this use?

m3avrck’s picture

m3avrck commented

Yeah, although this looks ok, I'm not 100% sold on this.

Are there any Drupal themes, whether in core, or that can be downloaded, that exhibit this effect?

Adding position:relative can cause some quirkiness so this needs to be confirmed in all the major browsers as well.

For now, I would say it's just as easy to throw this in your *custom* theme:

.blocks-region {
position:relative;
z-index:99
}

I don't see this as a global problem across all themes only specific to certain themes. As such, it's just as easy for those specific themes to add this code.

Undecided if that should be in Drupal or not -- if it doesn't fix any core themes, I'm leaning towards no.

Neil? Steven?

anders.fajerson’s picture

anders.fajerson commented

I'm with m3avrck on this, it could just as well be in the custom theme.

Steven’s picture

Steven commented
Status: Needs review » Closed (won't fix)

Given that there is no mention of a single specific theme in this issue that has this problem, I'm marking this as won'tfix.

If the block region markers are being overlapped, then chances are good that other things in the sidebars are being overlapped too. The theme author will have to fix this himself.